Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update assert in EmitConversion to allow for pointer subtraction #67445

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Update assert in EmitConversion to allow for pointer subtraction #67445

merged 2 commits into from
Mar 22, 2023

Conversation

cston
Copy link
Member

@cston cston commented Mar 22, 2023 •
edited
Loading

@cston cston requested a review from a team as a code owner March 22, 2023 19:31
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 22, 2023
AlekseyTs
AlekseyTs approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 2)

@cston cston merged commit efbc083 into dotnet:main Mar 22, 2023
@cston cston deleted the 67041 branch March 22, 2023 22:54
@ghost ghost added this to the Next milestone Mar 22, 2023
@allisonchou allisonchou modified the milestones: Next, 17.6 P3 Mar 28, 2023
@jcouv jcouv mentioned this pull request May 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

Assignees
No one assigned
Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.6 P3
Development

Successfully merging this pull request may close these issues.

Assert compiling dotnet/runtime in EmitConversions
4 participants
@cston @333fred @AlekseyTs @allisonchou