Consistently return the same value from MethodSymbol.IteratorElementTypeWithAnnotations API #65291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypeWithAnnotations API Fixes dotnet#40014.
|
@dotnet/roslyn-compiler Please review |
jcouv
reviewed
Nov 9, 2022
| var local = model.GetDeclaredSymbol(declaration).GetSymbol<MethodSymbol>(); | ||
|
|
||
| Assert.True(local.IsIterator); | ||
| Assert.Equal("System.Int32", local.IteratorElementTypeWithAnnotations.ToTestDisplayString()); |
There was a problem hiding this comment.
nit: do we have a test for calling IteratorElementTypeWithAnnotations on a non-iterator method (the null case)? #Closed
There was a problem hiding this comment.
do we have a test for calling IteratorElementTypeWithAnnotations on a non-iterator method (the null case)?
I do not know. Is there a specific concern?
There was a problem hiding this comment.
Never mind, I thought it was a public API.
jcouv
reviewed
Nov 9, 2022
| @@ -2366,8 +2366,22 @@ public unsafe IEnumerable<int> M4(int* a) | |||
| })(); | |||
| } | |||
| }"; | |||
| CreateCompilation(src, options: TestOptions.UnsafeDebugDll) | |||
| .VerifyDiagnostics( | |||
| var comp = CreateCompilation(src, options: TestOptions.UnsafeDebugDll, parseOptions: TestOptions.RegularNext.WithFeature("run-nullable-analysis", "never")); | |||
There was a problem hiding this comment.
Why skip nullable analysis? #Closed
There was a problem hiding this comment.
Why skip nullable analysis?
Because it binds the body before we can get the symbol, which defeats the purpose of the test.
|
@dotnet/roslyn-compiler For the second review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40014.