Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ImportCompletion feature flag and enable by default #65259

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Remove ImportCompletion feature flag and enable by default #65259

merged 1 commit into from
Nov 10, 2022

Conversation

genlu
Copy link
Member

@genlu genlu commented Nov 7, 2022

The feature flag has been enabled publicly since 17.3 rtw. This would make the feature on by default and remove the feature flag.

@genlu genlu requested a review from a team as a code owner November 7, 2022 20:43
@genlu genlu force-pushed the CompletionOption branch 2 times, most recently from aed5c19 to 985519a Compare November 7, 2022 23:47
@genlu genlu merged commit 6a0c11c into dotnet:main Nov 10, 2022
@genlu genlu deleted the CompletionOption branch November 10, 2022 19:58
@ghost ghost added this to the Next milestone Nov 10, 2022
@allisonchou allisonchou mentioned this pull request Nov 17, 2022
Closed
@allisonchou allisonchou modified the milestones: Next, 17.5 P2 Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
17.5 P2
Development

Successfully merging this pull request may close these issues.
3 participants
@genlu @CyrusNajmabadi @allisonchou