Revert "Scoped implicitly-typed lambda parameters (#64680)" #64986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5bf1a43.
cston
approved these changes
Oct 26, 2022
|
@AlekseyTs @RikkiGibson for second review. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From discussion with Mads and Chuck, implicitly-typed lambda parameters should only receive a type during anonymous function conversion. With regards to
refandscoped, both should behave the same, they should not flow to the implicitly-typed lambda parameters.The first commit reverts commit 5bf1a43 (ie PR #64680). The second commit adds the tests back plus a couple more.
Corresponding spec change: dotnet/csharplang#6595
Filed issue #64984 (conversion existence affects overload resolution)
Filed issue #64985 (lambda parameter symbol ref-kind incorrect)
Relates to test plan #59194