Extract name recommendation logic into a separate type #64981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c488c89 to
4bb6117
Compare
| [Shared] | ||
| internal partial class DeclarationNameCompletionProvider : LSPCompletionProvider | ||
| { | ||
| private ImmutableArray<DeclarationNameRecommender> Recommenders { get; } |
There was a problem hiding this comment.
Already a readonly property
| description: CSharpFeaturesResources.Suggested_name.ToSymbolDisplayParts()); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
is this all a move? did anything hange?
There was a problem hiding this comment.
Yes. The only change (except simply moving code around) is extracting code into methods. I intentionally excluded any real change to make review of the next PR easier.
| using Microsoft.CodeAnalysis.Shared.Extensions; | ||
| using static Microsoft.CodeAnalysis.Diagnostics.Analyzers.NamingStyles.SymbolSpecification; | ||
|
|
||
| namespace Microsoft.CodeAnalysis.CSharp.Completion.Providers |
There was a problem hiding this comment.
very confused why github didn't pick upt he rename. is this substantively chnaged at all?
...Portable/Completion/CompletionProviders/DeclarationName/DeclarationNameCompletionProvider.cs
Outdated
Show resolved
Hide resolved
0e2060f to
19a0f5f
Compare
CyrusNajmabadi
approved these changes
Oct 26, 2022
19a0f5f to
c7b399f
Compare
ryzngard
approved these changes
Oct 26, 2022
c7b399f to
7e470ce
Compare
This was referenced Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just refactor the code w/o any change to the logic. I have extracted the code for declaration name recommendation into a separate type. The goal is to make name recommender an extension point so IntelliCode can provide suggestion as well, which will be in a follow up PR.