Semantic snippets - while snippet #64893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DoctorKrolic
commented
Oct 21, 2022
...table/Snippets/SnippetProviders/AbstractConditionalExpressionAndBlockBasedSnippetProvider.cs
Outdated
Show resolved
Hide resolved
2 tasks
akhera99
reviewed
Oct 24, 2022
src/Features/CSharp/Portable/Snippets/CSharpWhileLoopSnippetProvider.cs
Outdated
Show resolved
Hide resolved
| return newIndentation.GetIndentationString(parsedDocument.Text, syntaxFormattingOptions.UseTabs, syntaxFormattingOptions.TabSize) + newLine; | ||
| } | ||
|
|
||
| protected override async Task<Document> AddIndentationToDocumentAsync(Document document, int position, ISyntaxFacts syntaxFacts, CancellationToken cancellationToken) |
There was a problem hiding this comment.
The indentation should probably be abstracted out for every block - since most of them are exactly the same. I'll do that in a follow-up PR
There was a problem hiding this comment.
The vast majority of snippets have such block, so this definitely needs an abstraction. I am only not sure how it will work if semantic snippets become a VB thing as well
...table/Snippets/SnippetProviders/AbstractConditionalExpressionAndBlockBasedSnippetProvider.cs
Outdated
Show resolved
Hide resolved
|
From a cursory glance, this looks really good! I'll do a more in depth review by the beginning of the week |
akhera99
reviewed
Oct 24, 2022
...ers/Snippets/AbstractCSharpConditionExpressionAndBlockBasedSnippetCompletionProviderTests.cs
Outdated
Show resolved
Hide resolved
akhera99
reviewed
Oct 26, 2022
src/Features/Core/Portable/Snippets/SnippetProviders/AbstractWhileLoopSnippetProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/Core/Portable/Snippets/SnippetProviders/AbstractWhileLoopSnippetProvider.cs
Outdated
Show resolved
Hide resolved
|
Looks good to me with the fixes I suggested! |
akhera99
approved these changes
Oct 26, 2022
Co-authored-by: Ankita Khera <40616383+akhera99@users.noreply.github.com>
Co-authored-by: Ankita Khera <40616383+akhera99@users.noreply.github.com>
|
Looks good, thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
ifandwhilestatements are very similar, but there was a semantic snippet only forif. I tried to abstract as lot of logic as possible, but unfortunatelyIfStatementSyntaxandWhileStatementSyntaxdon't have a common ancestor, so there is still some amount of code duplication(@akhera99 You are the master here, waiting for your review)