Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for delegate creation inside an explicitly-converted tuple expression #64882

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Account for delegate creation inside an explicitly-converted tuple expression #64882

merged 2 commits into from
Oct 26, 2022

Conversation

333fred
Copy link
Member

@333fred 333fred commented Oct 20, 2022

Fixes #64774.

@333fred 333fred requested a review from a team as a code owner October 20, 2022 23:23
@333fred 333fred added the Feature - IOperation IOperation label Oct 20, 2022
@333fred
Copy link
Member Author

333fred commented Oct 20, 2022

@dotnet/roslyn-compiler for review.

AlekseyTs
AlekseyTs approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 1), additional tests are suggested

@333fred
Copy link
Member Author

333fred commented Oct 21, 2022

@dotnet/roslyn-compiler for a second review.

@333fred 333fred merged commit b580572 into dotnet:main Oct 26, 2022
@333fred 333fred deleted the delegate-isimplicit branch October 26, 2022 20:47
@ghost ghost added this to the Next milestone Oct 26, 2022
@allisonchou allisonchou mentioned this pull request Nov 1, 2022
Closed
@allisonchou allisonchou modified the milestones: Next, 17.5 P2 Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@chsienki chsienki chsienki approved these changes

Assignees
No one assigned
Labels
Area-Compilers Feature - IOperation IOperation
Projects
None yet
Milestone
17.5 P2
Development

Successfully merging this pull request may close these issues.

Building crash using newer .NET SDK than 6.0.203
4 participants
@333fred @AlekseyTs @chsienki @allisonchou