-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify diagnostic when constant pattern has non-constant conversion to input type #64741
Changes from all commits
2011410
b00555d
b1d900f
4aad412
540293f
6dc0cbf
b6ff4d6
abc35ce
d06febf
5e13b6c
c9d58cc
ccbec6a
887bed0
d8d71aa
554394f
2500017
676e236
9c3e2ff
84e660f
5bc527a
6391b38
42e816e
da83f74
767dd67
4d67f82
f66b852
7082eb9
6079224
f899ed8
e966df6
64c9594
c7047bb
de4251e
8a996ab
601b59a
ab89a3a
4698f28
feef4af
9aa4323
5fdf010
d17db0c
eb43863
bc11149
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the suggestion from #64741 (comment) was to not introduce any new logic, and change this to just use the new error code you added, passing in the
inputType
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the check for user defined conversions. However a few tests where the input type was unknown you'd end up with messages like
Constant value of type '?' expected
. Which I dont think improves upon the existing behavior.For this reason I've now implemented to conditionally return the original
ERR_ConstantExpected
when the inputType is an error symbol. If this is undesirable please let me know.