Revert "Deprecate usage of Workspace in TextLoader (breaking change)" #64228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cosifne
approved these changes
Sep 22, 2022
|
Tag @tmat and @jasonmalinowski to aware of this revert. |
|
VS Insertion with exceptions (internal only): https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/425022 |
|
The analysis with help from @333fred is this an explicit use of the text loader here: Which now hits the NotImplementedException. |
tmat
added a commit
to tmat/roslyn
that referenced
this pull request
Sep 23, 2022
…change) (dotnet#63616)" (dotnet#64228)" This reverts commit 9d2a58e.
tmat
added a commit
to tmat/roslyn
that referenced
this pull request
Sep 26, 2022
…change) (dotnet#63616)" (dotnet#64228)" This reverts commit 9d2a58e.
tmat
added a commit
to tmat/roslyn
that referenced
this pull request
Sep 26, 2022
…change) (dotnet#63616)" (dotnet#64228)" This reverts commit 9d2a58e.
tmat
added a commit
to tmat/roslyn
that referenced
this pull request
Sep 28, 2022
…change) (dotnet#63616)" (dotnet#64228)" This reverts commit 9d2a58e.
tmat
added a commit
to tmat/roslyn
that referenced
this pull request
Sep 28, 2022
…change) (dotnet#63616)" (dotnet#64228)" This reverts commit 9d2a58e.
tmat
added a commit
to tmat/roslyn
that referenced
this pull request
Oct 7, 2022
…change) (dotnet#63616)" (dotnet#64228)" This reverts commit 9d2a58e.
tmat
added a commit
that referenced
this pull request
Oct 10, 2022
* Revert "Revert "Deprecate usage of Workspace in TextLoader (breaking change) (#63616)" (#64228)" This reverts commit 9d2a58e. * Implement override detection * Add ChecksumAlgorithm to DocumentAttributes and ProjectAttributes * Ban more overloads of SyntaxTree.Create * LoadChecksum * LoadTextOptions * Better banned symbols comment * Remove checksum alg from TreeAndVersion * More feedback * Remove DocumentInfo.LoadTextOptions * Make CanReloadText internal * EnC: use the document snapshot when validating PDB checksum * Fix style * Make new TextLoader APIs internal * Feedback * PdbMatchingSourceTextProvider * Move GetSyntaxTreeFilePath to DocumentAttributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #63616. Seeing thousands of exceptions on VS insertion.