Disable quickinfo on new inline rename #63907
Conversation
| return; | ||
| } | ||
|
|
||
| await infoSession.DismissAsync().ConfigureAwait(false); |
There was a problem hiding this comment.
If I read the code correctly, we are dismissing the QuickInfo when rename is triggered as well as returning no QuickInfo item when there's an active rename session.
There was a problem hiding this comment.
Correct. That's required because dismissing the active session alone doesn't prevent another one being created. We can't actively turn off QuickInfo altogether, so our workaround is to return no information.
There was a problem hiding this comment.
might be worth documenting.
|
Is it possible to unittest this? |
| } | ||
|
|
||
| public async Task<IntellisenseQuickInfoItem> GetQuickInfoItemAsync(IAsyncQuickInfoSession session, CancellationToken cancellationToken) | ||
| { | ||
| if (_globalOptions.GetOption(InlineRenameUIOptions.UseInlineAdornment) && _inlineRenameService.ActiveSession is not null) | ||
| return null; |
There was a problem hiding this comment.
consider doc'ing both sides to mention the other.
There was a problem hiding this comment.
also doc why we're doing this. basically that quick info otherwise can go on top of hte rename dialog, blocking it from the user.
No description provided.