Disallow ref field to ref struct #62186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RikkiGibson
reviewed
Jun 28, 2022
| .class public sealed R2 extends [mscorlib]System.ValueType | ||
| { | ||
| .custom instance void [mscorlib]System.Runtime.CompilerServices.IsByRefLikeAttribute::.ctor() = (01 00 00 00) | ||
| .field public valuetype R1& F |
There was a problem hiding this comment.
unrelated: do we give a use-site error when a non-ref struct contains a ref field?
There was a problem hiding this comment.
do we give a use-site error when a non-
ref structcontains a ref field?
No, we're not reporting a use-site error for use of such a field currently. There is an item in the test plan, and I'll add this in a follow-up PR.
RikkiGibson
approved these changes
Jun 28, 2022
|
Do we have an issue tracking the work to re-enable this scenario? |
jaredpar
approved these changes
Jun 29, 2022
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallow
reffields ofref structtype, to simplify escape analysis.Relates to test plan #59194