Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UseAutoProperty for record structs #56474

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Fix UseAutoProperty for record structs #56474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Analyzers/CSharp/Analyzers/UseAutoProperty/CSharpUseAutoPropertyAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ private void AnalyzeMemberDeclaration(
}
else if (member.IsKind(SyntaxKind.ClassDeclaration, out TypeDeclarationSyntax? typeDeclaration) ||
member.IsKind(SyntaxKind.StructDeclaration, out typeDeclaration) ||
member.IsKind(SyntaxKind.RecordDeclaration, out typeDeclaration))
member.IsKind(SyntaxKind.RecordDeclaration, out typeDeclaration) ||
member.IsKind(SyntaxKind.RecordStructDeclaration, out typeDeclaration))
Comment on lines 53 to +56
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else if (member is TypeDeclarationSyntax typeDeclaration)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, n/m. you're not checking interfaces.

{
// If we have a class or struct, recurse inwards.
AnalyzeMembers(context, typeDeclaration.Members, analysisResults);
Expand Down
15 changes: 15 additions & 0 deletions src/Analyzers/CSharp/Tests/UseAutoProperty/UseAutoPropertyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2533,6 +2533,21 @@ await TestInRegularAndScript1Async(
public readonly int P => i;
}",
@"struct S
{
public readonly int P { get; }
}");
}

[Fact, Trait(Traits.Feature, Traits.Features.CodeActionsUseAutoProperty)]
public async Task TestPropertyInRecordStruct()
{
await TestInRegularAndScript1Async(
@"record struct S
{
[|int i|];
public readonly int P => i;
}",
@"record struct S
{
public readonly int P { get; }
}");
Expand Down