Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .Any extension of ImmutableArray(Of Symbol) #48980

Merged
merged 1 commit into from
Nov 13, 2020

Conversation

AdamSpeight2008
Copy link
Contributor

Removes the explicit For Each loop and replace with a call to the extension method .Any on the ImmutableArray(Of Symbol)

Removes the explicit For Each loop and replace with a call to the extension method `.Any` on the `ImmutableArray(Of Symbol)`
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to come with performance data indicating that the lambda, and delegate-invocation-overhead is not a problem.

@sharwell
Copy link
Member

@CyrusNajmabadi This change was submitted at my request

@333fred 333fred dismissed CyrusNajmabadi’s stale review November 12, 2020 01:21

Was submitted as requested.

@333fred
Copy link
Member

333fred commented Nov 12, 2020

@dotnet/roslyn-compiler for a second review.

@333fred 333fred merged commit de99c46 into dotnet:master Nov 13, 2020
@ghost ghost added this to the Next milestone Nov 13, 2020
@333fred
Copy link
Member

333fred commented Nov 13, 2020

Thanks @AdamSpeight2008

333fred added a commit to 333fred/roslyn that referenced this pull request Nov 16, 2020
* upstream/master: (148 commits)
  Remove unnecessary ArrayBuilder in MakeCallWithNoExplicitArgument (dotnet#49377)
  Revert "Skip binary for determinism checking"
  Use deterministic metadata names for emitted anonymous type fields. (dotnet#49370)
  Reuse LSP solutions if they don't need re-forking (dotnet#49305)
  Small nullability fixes (dotnet#49279)
  Create default arguments during binding (dotnet#49186)
  Clean nits
  Backport dotnet#48420 to release/dev16.8 (dotnet#49357)
  Rewrite AnalyzeFileReference.GetSupportedLanguages without LINQ (dotnet#49337)
  Use .Any extension of ImmutableArray(Of Symbol) (dotnet#48980)
  fix 'remove unnecessary cast' when doing bitwise ops on unsigned values.
  Harden, document, cross-link XunitDisposeHook
  Simplify x86 hook
  Fix split comment exporting for VB.
  Code style fix
  Overwrite xunit's app domain handling to not call AppDomain.Unload
  Revert pragma suppression
  Remove blank line
  Revert file
  Move block structure code back to Features layer
  ...
@allisonchou allisonchou modified the milestones: Next, 16.9.P2 Nov 24, 2020
@AdamSpeight2008 AdamSpeight2008 deleted the patch-12 branch August 5, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants