Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix graph query for records #48451

Merged
merged 2 commits into from
Oct 12, 2020
Merged

Fix graph query for records #48451

merged 2 commits into from
Oct 12, 2020

Conversation

Youssef1313
Copy link
Member

Fixes #48449

Before:

image

After:

image

@Youssef1313 Youssef1313 requested a review from a team as a code owner October 8, 2020 19:23
Youssef1313
Youssef1313 commented Oct 8, 2020
View reviewed changes
Youssef1313
Youssef1313 commented Oct 8, 2020
View reviewed changes
src/VisualStudio/Core/Test/Progression/ContainsGraphQueryTests.vb
Comment on lines +41 to +42
<Node Id="(@3 Type=R1)" Category="CodeSchema_Class" CodeSchemaProperty_IsInternal="True" CommonLabel="R1" Icon="Microsoft.VisualStudio.Class.Internal" Label="R1"/>
<Node Id="(@3 Type=R2)" Category="CodeSchema_Class" CodeSchemaProperty_IsInternal="True" CommonLabel="R2" Icon="Microsoft.VisualStudio.Class.Internal" Label="R2"/>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The records are currently classified as classes (i.e. shows with the same icon as classes) (See the following image):

image

This might be related to #48127

The icons seem to be internal (not in Roslyn repo), and I also think part of the implementation is internal too.

@jinujoseph jinujoseph added Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Oct 8, 2020
@jcouv jcouv added the Feature - Records Records label Oct 8, 2020
jasonmalinowski
jasonmalinowski reviewed Oct 8, 2020
View reviewed changes
Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good but let's revert the Roslyn.sln change.

@jasonmalinowski jasonmalinowski self-assigned this Oct 8, 2020
@jasonmalinowski jasonmalinowski merged commit 04481d2 into dotnet:master Oct 12, 2020
@ghost ghost added this to the Next milestone Oct 12, 2020
@jasonmalinowski
Copy link
Member

Thanks @Youssef1313 for the fix!

@Youssef1313 Youssef1313 deleted the records-graph-query branch October 12, 2020 18:08
@Cosifne Cosifne modified the milestones: Next, 16.9.P1 Oct 12, 2020
@Youssef1313 Youssef1313 mentioned this pull request Feb 18, 2021
Closed
92 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski left review comments

@davidwengier davidwengier davidwengier approved these changes

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees

@jasonmalinowski jasonmalinowski

@CyrusNajmabadi CyrusNajmabadi

@jcouv jcouv

Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. Feature - Records Records
Projects
None yet
Milestone
16.9.P1
Development

Successfully merging this pull request may close these issues.

Expanding a file in Visual Studio shows classes but not records
7 participants
@Youssef1313 @jasonmalinowski @davidwengier @CyrusNajmabadi @jinujoseph @jcouv @Cosifne