Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customizable Obsolete diagnostics #42518

Merged
merged 21 commits into from
Mar 30, 2020
Merged

Customizable Obsolete diagnostics #42518

merged 21 commits into from
Mar 30, 2020

Conversation

RikkiGibson
Copy link
Contributor

Closes #42119

This is still a WIP, but I would appreciate some review on the general approach in use. Several things still need testing, including diagnostics on usage of symbols from metadata.

@RikkiGibson RikkiGibson requested a review from a team as a code owner March 17, 2020 23:46
@RikkiGibson RikkiGibson added the PR For Personal Review Only The PR doesn’t require anyone other than the developer to review it. label Mar 18, 2020
@RikkiGibson

This comment has been minimized.

Sign in to view
@RikkiGibson RikkiGibson removed the PR For Personal Review Only The PR doesn’t require anyone other than the developer to review it. label Mar 18, 2020
@jcouv jcouv added PR For Personal Review Only The PR doesn’t require anyone other than the developer to review it. and removed PR For Personal Review Only The PR doesn’t require anyone other than the developer to review it. labels Mar 18, 2020
@AlekseyTs
Copy link
Contributor

AlekseyTs commented Mar 19, 2020 •
edited
Loading

I would expect some changes on VB side as well. #Closed

@AlekseyTs
Copy link
Contributor

AlekseyTs commented Mar 19, 2020 •
edited
Loading

Done with review pass (iteration 4) #Closed

@RikkiGibson
Copy link
Contributor Author

@terrajobst Yes

@AlekseyTs
Copy link
Contributor

AlekseyTs commented Mar 27, 2020 •
edited
Loading

Done with review pass (iteration 15) #Closed

@AlekseyTs
Copy link
Contributor

AlekseyTs commented Mar 27, 2020 •
edited
Loading

Done with review pass (iteration 18) #Closed

@RikkiGibson RikkiGibson requested a review from a team March 30, 2020 19:50
@RikkiGibson
Copy link
Contributor Author

@dotnet/roslyn-compiler Please review

AlekseyTs
AlekseyTs approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (iteration 20)

@RikkiGibson RikkiGibson merged commit 34fdb69 into dotnet:master Mar 30, 2020
@ghost ghost added this to the Next milestone Mar 30, 2020
@RikkiGibson RikkiGibson deleted the obsoleteattribute branch March 30, 2020 23:14
@sharwell sharwell modified the milestones: Next, temp, 16.6.P3 Apr 6, 2020
@Joe4evr Joe4evr mentioned this pull request Apr 8, 2020
Closed
@jeffhandley jeffhandley mentioned this pull request Jul 20, 2020
Closed
@RikkiGibson RikkiGibson mentioned this pull request Sep 3, 2020
Merged
@eerhardt eerhardt mentioned this pull request May 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrajobst terrajobst terrajobst left review comments

@jaredpar jaredpar jaredpar approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

Assignees
No one assigned
Labels
Area-Compilers
Projects
None yet
Milestone
16.6.P3
Development

Successfully merging this pull request may close these issues.

Honor new properties on ObsoleteAttribute
6 participants
@RikkiGibson @AlekseyTs @jaredpar @terrajobst @sharwell @jcouv