-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MemoryHelper.cs: Don't call Win32 API on Unix #38239
Conversation
These failures aren't related to your change:
Pinging our @dotnet/roslyn-infrastructure team to see what is going on here. |
/azp run |
Commenter does not have sufficient privileges for PR 38239 in repo dotnet/roslyn |
a8bfb39
to
dda4b1b
Compare
@akoeplinger do you know what privs are necessary to get the |
@jaredpar it seems to be some bug with AzDO. You can work around it by adding the user as a collaborator to the GitHub repo with I'm not sure if this is tracked by AzDO folks yet (the behavior makes no sense since you could just push to the PR to trigger another build so it's not a security issue). |
- System.Environment.IsRunningOnWindows doesn't exist in the dotnet/runtime corelib - Microsoft.CodeAnalysis.CompilerServer.MemoryHelper.IsMemoryAvailable was used to workaround a bug that was fixed 2 years ago with dotnet/roslyn#38239 and should no longer be relevant
- System.Environment.IsRunningOnWindows doesn't exist in the dotnet/runtime corelib - Microsoft.CodeAnalysis.CompilerServer.MemoryHelper.IsMemoryAvailable was used to workaround a bug that was fixed 2 years ago with dotnet/roslyn#38239 and should no longer be relevant
Fixes #38211