Allow VisualStudioExperimentationService to initialize on a background thread #30916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/VisualStudio/Core/Def/Experimentation/VisualStudioExperimentationService.cs
Outdated
Show resolved
Hide resolved
|
Is there a reason we need to have any blocking here? can we not just make the API async and allow getting this service through normal JTF means one demand? |
src/VisualStudio/Core/Def/Experimentation/VisualStudioExperimentationService.cs
Show resolved
Hide resolved
src/VisualStudio/Core/Def/Experimentation/VisualStudioExperimentationService.cs
Show resolved
Hide resolved
src/VisualStudio/Core/Def/Experimentation/VisualStudioExperimentationService.cs
Outdated
Show resolved
Hide resolved
f741788 to
9ddfbf0
Compare
|
@CyrusNajmabadi I will submit the asynchronous form as a separate pull request (#30929) targeting master, which we can merge after this simpler pull request moves forward |
src/VisualStudio/Core/Def/Experimentation/VisualStudioExperimentationService.cs
Show resolved
Hide resolved
|
Approved to merge once green |
mavasani
approved these changes
Nov 7, 2018
jasonmalinowski
approved these changes
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30892
Customer scenario
When the first Roslyn document opened in the editor is opened via the Navigate To feature, the Roslyn package fails to load and its IDE features are missing substantial functionality.
Bugs this fixes
#30892
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/725190
Workarounds, if any
Open a source document before using Navigate To.
Risk
Low. In the event other initialization code has bugs (fails to follow required threading rules of the host application), the IDE could hang (deadlock) during the test scenario. However, this is unlikely to result in loss of data because changes cannot be made to most source documents prior to opening the first source document.
Performance impact
Code paths are not altered outside of the broken scenario.
Is this a regression from a previous update?
Unknown.
Root cause analysis
Manual testing scenarios should be updated to cover this case.
How was the bug found?
Internal report.
Test documentation updated?
Not yet.