Fix ref and out keyword completion to appear in local functions #22374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet/roslyn-ide |
rchande
approved these changes
Sep 27, 2017
sharwell
requested changes
Sep 27, 2017
| @@ -19,7 +19,8 @@ public static bool IsDelegateOrConstructorOrMethodParameterList(this SyntaxNode | |||
| return | |||
| node.IsParentKind(SyntaxKind.MethodDeclaration) || | |||
| node.IsParentKind(SyntaxKind.ConstructorDeclaration) || | |||
| node.IsParentKind(SyntaxKind.DelegateDeclaration); | |||
| node.IsParentKind(SyntaxKind.DelegateDeclaration) || | |||
| node.IsParentKind(SyntaxKind.LocalFunctionStatement); | |||
There was a problem hiding this comment.
❗️ The method name appears to be misleading now.
|
Closing this PR. As @sharwell mentioned this has already been fixed. Thanks Sam! |
|
Added tests for ref and out in another PR #22388 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22253
Customer scenario
If customer is in a local function,
outandrefwill not appear in the completion list when adding a parameterBugs this fixes:
#22253
Workarounds, if any
customer can type
outorrefinstead of choosing it from the completion listRisk
Low, should only impact keyword completion feature
Performance impact
Low, minor code fix
Is this a regression from a previous update?
No
Root cause analysis:
Local functions were not included as a possible place for
outandrefkeywords to be offered in completionHow did we miss it? What tests are we adding to guard against it in the future?
Did not consider local functions. New tests have been added for
refandoutHow was the bug found?
Issue filed by team member
Test documentation updated?
N/A