Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove syntax of "in" parameters #22182

Merged
merged 1 commit into from
Sep 19, 2017
Merged

Remove syntax of "in" parameters #22182

merged 1 commit into from
Sep 19, 2017

Conversation

OmarTawfik
Copy link
Contributor

@OmarTawfik OmarTawfik commented Sep 18, 2017 •
edited
Loading

No description provided.

@OmarTawfik OmarTawfik self-assigned this Sep 18, 2017
@OmarTawfik OmarTawfik added Area-Compilers Area-IDE Feature - Readonly References Readonly References PR For Personal Review Only The PR doesn’t require anyone other than the developer to review it. labels Sep 18, 2017
@OmarTawfik OmarTawfik added this to the 15.5 milestone Sep 18, 2017
@alrz
Copy link
Member

alrz commented Sep 19, 2017

Remove syntax of "in" parameters

what happened to in parameters?

@OmarTawfik
Copy link
Contributor Author

@alrz this branch supported initially two ways of defining read only reference parameters, either ref readonly or in, as a prototype. This PR removes the latter before this feature branch is merged to master.

@OmarTawfik OmarTawfik removed the PR For Personal Review Only The PR doesn’t require anyone other than the developer to review it. label Sep 19, 2017
@OmarTawfik
Copy link
Contributor Author

cc @dotnet/roslyn-compiler @dotnet/roslyn-ide @VSadov

@alrz
Copy link
Member

alrz commented Sep 19, 2017

@OmarTawfik I see that. I mean, why? Is it discarded or pushed to another version?

@OmarTawfik
Copy link
Contributor Author

@alrz yes, it was dropped in favor of ref readonly.

jasonmalinowski
jasonmalinowski approved these changes Sep 19, 2017
View reviewed changes
Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a new change needed to ensure "ref readonly" is suggested correctly in the keyword recommenders?

@OmarTawfik
Copy link
Contributor Author

@jasonmalinowski it was already implemented in an earlier PR.

jcouv
jcouv approved these changes Sep 19, 2017
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

VSadov
VSadov approved these changes Sep 19, 2017
View reviewed changes
Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OmarTawfik OmarTawfik merged commit 7babe0e into dotnet:features/readonly-ref Sep 19, 2017
@OmarTawfik OmarTawfik deleted the remove-in-parameters branch September 19, 2017 19:48
@jcouv jcouv mentioned this pull request Sep 19, 2017
Closed
@jkotas jkotas mentioned this pull request Oct 7, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpar jaredpar jaredpar approved these changes

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

@VSadov VSadov VSadov approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@OmarTawfik OmarTawfik

Labels
Area-Compilers Area-IDE cla-already-signed Feature - Readonly References Readonly References
Projects
None yet
Milestone
15.5
Development

Successfully merging this pull request may close these issues.
7 participants
@OmarTawfik @alrz @jaredpar @jasonmalinowski @VSadov @jcouv @dnfclas