Fix error message when passing in parameters by ref #20337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @VSadov @dotnet/roslyn-compiler for review. |
AlekseyTs
reviewed
Jun 23, 2017
| @@ -9259,59 +9259,139 @@ static class E | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void CircularImplicitConversions() | |||
There was a problem hiding this comment.
CircularImplicitConversions [](start = 20, length = 27)
What happened with this test? #Resolved
There was a problem hiding this comment.
Something strange with the merge. The test was not deleted, but the diff shows as it was.
In reply to: 123671280 [](ancestors = 123671280)
|
Done with review pass. |
|
@dotnet/roslyn-compiler - please review. This one is 9 days old. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18477
Added tests for permutations for all ref kinds, even the ones that fail to parse, like
Method(ref readonly x).