Don't show completionlist completion after dot #18788
Conversation
|
Tag @dotnet/roslyn-ide for review |
|
retest this please |
|
@dotnet/roslyn-infrastructure I'm encountering problems with CSharpSyntaxTest that aren't related to my change: rror CS0103: The name 'CreateCompilationWithMscorlib' does not exist in the current context [D:\j\workspace\windows_deter---bd1d49d3\src\Compilers\CSharp\Test\Syntax\CSharpCompilerSyntaxTest.csproj] CSharpScriptingTest -> D:\j\workspace\windows_deter---bd1d49d3\Binaries\Debug\Dlls\CSharpScriptingTest\Microsoft.CodeAnalysis.CSharp.Scripting.UnitTests.dll Known? |
|
Should be fixed now. |
|
@tmat Thanks! |
|
retest this please |
|
retest windows_debug_vs-integration_prtest |
|
retest windows_release_unit32_prtest |
|
retest this please |
|
Failures unrelated. Anyone else on @dotnet/roslyn-ide want to review? |
|
@dotnet-bot retest this please. |
|
Tag @MattGertz for ask mode approval |
|
Approved pending tests. |
|
retest perf_correctness_prtest |
|
retest windows_release_vs-integration_prtest |
1 similar comment
|
retest windows_release_vs-integration_prtest |
Customer scenario
Customer starts using a member from
System.Pens,System.Brushes, etc. (Any type that uses thecompletionlistXML documentation tag). They insert one item but want to replace it with a different item. Intellisense gets in their way and insertsPens.Blahagain instead ofBlahBugs this fixes:
#18787
Workarounds, if any
None
Risk
Very low, we now just check to see if the target token is a dot token.
Performance impact
Very low, we actually will show completionlist completion less than we did before.
Is this a regression from a previous update?
No
Root cause analysis:
This was a test hole, a test has been added to cover the scenario.
How was the bug found?
Customer reported