Scanner(Unification) & TryPeek #1727
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de readability. CanGetCharAtOffset -> CanGet PeekAheadChar -> Peek PeakChar -> Peek
Modified ScannerXML to use NextAre and NextIs, the remaining candidates are mostly suitable for TryPeek (not yet implemented)
Fixed the failing `Debug.Assert`s that used `AreNext(0, " ")` as the failure was being cause by CanGet looking to far ahead (off by one)
# By Jared Parsons (22) and others # Via Tomáš Matoušek (15) and others * 'master' of https://github.com/dotnet/roslyn: (137 commits) Remove some unncessary usings in v1 Diagnostic incremental analyzer. Don't report any locations in the error log file for diagnostics with Location.None. Fixes dotnet#1582 Collapse switch cases Update DuplicateTypesAndMethodsDifferentAssemblies tests Fix typo: teh -> the Incorporate PR feedback Fix timestamp written to Debug Image Directory Port EvaluationContext changes to VB Use MetadataReader to extract analyzer display names. Add DuplicateTypesAndMethodsDifferentAssemblies test Fix CodeFixService.GetProjectDiagnostics to handle compilation end diagnostics. Currently it was just force computing all document diagnostics, not the project diagnostics, which executes the compilation end actions. Additionally, also fix the BatchFixAllProvider to correctly handle compilation end diagnostics. Actually write out the MemoryStream Respond to PR feedback Missed a file [EnC] Fix ArgumentException in SymbolMatcher More CoreFx porting work Adding additional tests Incorporate PR feedback [EnC] Fix ArgumentException in SymbolMatcher Jenkins should use the full Roslyn.sln ... Conflicts: src/Compilers/VisualBasic/Portable/Scanner/Scanner.vb src/Compilers/VisualBasic/Portable/Scanner/ScannerInterpolatedString.vb src/Compilers/VisualBasic/Portable/Scanner/ScannerXml.vb src/Compilers/VisualBasic/Portable/Scanner/XmlDocComments.vb src/Compilers/VisualBasic/Portable/Scanner/XmlTokenFactories.vb
|
@gafter @AlekseyTs Could you please look at this and decide if it is worth moving forward with it? |
|
This looks very much like several other PRs that you have already submitted and closed. |
|
Please put your changes in #1463 for us to look at. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains a previously submitted PR(#1463), that PR as been included into this one as this pull request merges with the master branch
TryScanTokenandScanTokenFullWidth. (Scanner(unification) + TryPeek #1463)I retain those methods so not the break existing calls to them. The internals now call a common implementation method
ScanTokenCommon.This reduces the size of the sourcecode and the resulting IL (Debug)
TryPeek, that is a try variant ofPeek