Unification of the contents of TryScanToken and ScanTokenFullWidth. #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Small Refactoring + Use a common lengthWithMeyBeEquals + Change section to use IF( , ) instead.
Add in missing space after common in method calls to ScanTokenCommon
|
@dotnet-bot retest this please |
1 similar comment
|
@dotnet-bot retest this please |
|
Closing this PR as it is already covered by #1381. Please don't open multiple PRs for the same logical change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This #1381, I messed up my repos :-(