Improved error recovery for lambdas in a call with extra arguments. #11807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
|
|
||
| // We expect that we have been handed a list of arguments and a list of the | ||
| // formal parameter types they correspond to; all the details about named and | ||
| // optional parameters have already been dealt with. | ||
|
|
||
| // SPEC: For each of the method arguments Ei: | ||
| for (int arg = 0; arg < _arguments.Length; arg++) | ||
| var length = this.Length; | ||
| for (int arg = 0; arg < length; arg++) |
There was a problem hiding this comment.
a common idiom for this is: for (int arg = 0, n = this.Length; i < n; i++)
aa8f581 to
567d12f
Compare
This was referenced Jun 7, 2016
|
Test failure reported in #11818 |
| /// For error recovery, we allow a mismatch between the number of arguments and parameters | ||
| /// during type inference. This sometimes enables inferring the type for a lambda parameter. | ||
| /// </summary> | ||
| private int Length => System.Math.Min(_arguments.Length, _formalParameterTypes.Length); |
There was a problem hiding this comment.
Can we name this something more descriptive?
There was a problem hiding this comment.
|
I've revised this PR, adding a test for non-syntax-error scenario, and renaming a property. Pleas review revision. |
|
👍 |
|
LGTM |
|
@dotnet-bot retest windows_eta_open_prtest please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #557, #5498
@dotnet/roslyn-compiler Please review
@CyrusNajmabadi FYI