Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CheckFeatureAvailability should not have side-effects on binding via hasErrors in ForEachLoopBinder #65363

Closed
jcouv opened this issue Nov 11, 2022 · 0 comments · Fixed by #65366
Closed

CheckFeatureAvailability should not have side-effects on binding via hasErrors in ForEachLoopBinder #65363

jcouv opened this issue Nov 11, 2022 · 0 comments · Fixed by #65366
Assignees
@jcouv
Labels
Area-Compilers Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality
Milestone
17.5

Comments

@jcouv
Copy link
Member

jcouv commented Nov 11, 2022 •
edited
Loading

We should remove the side-effect on hasErrors in hasErrors |= !messageId.CheckFeatureAvailability( ... because some checks are conditional on hasErrors.

#65352 (comment)
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 11, 2022
@jcouv jcouv mentioned this issue Nov 11, 2022
Merged
@jcouv jcouv self-assigned this Nov 11, 2022
@jcouv jcouv added Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 11, 2022
@jcouv jcouv added this to the 17.5 milestone Nov 11, 2022
@jcouv jcouv mentioned this issue Nov 11, 2022
Merged
jcouv added a commit that referenced this issue Nov 14, 2022
@jcouv
Complete all foreach binding checks despite LangVer check (#65366)
3250b54 
Fixes #65363
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcouv jcouv

Labels
Area-Compilers Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality
Projects
None yet
Milestone
17.5
Development

Successfully merging a pull request may close this issue.

Complete all foreach binding checks despite LangVer check jcouv/roslyn
1 participant
@jcouv