Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove or reduce use of ParameterSymbol.DeclaredScope #63078

Closed
cston opened this issue Jul 29, 2022 · 1 comment · Fixed by #63787
Closed

Remove or reduce use of ParameterSymbol.DeclaredScope #63078

cston opened this issue Jul 29, 2022 · 1 comment · Fixed by #63787
Assignees
@cston
Labels
Area-Compilers Concept-Continuous Improvement Feature - Ref Fields
Milestone
Compiler.Next

Comments

@cston
Copy link
Member

cston commented Jul 29, 2022

Consider if we remove ParameterSymbol.DeclaredScope and use EffectiveScope only, or at least reduce the use of DeclaredScope perhaps to source parameters only.

Based on discussion from #62783 (comment)
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 29, 2022
@cston cston mentioned this issue Jul 29, 2022
Merged
@cston cston self-assigned this Jul 29, 2022
@jcouv
Copy link
Member

jcouv commented Aug 2, 2022

FYI, an upcoming PR of mine affects the semantics of this property (make it return true only for explicitly-scoped parameters, and moving the logic of implicitly scoping into EffectiveScope instead): #63134

@jcouv jcouv added this to the 17.4 milestone Aug 2, 2022
@jcouv jcouv added Concept-Continuous Improvement and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 2, 2022
@cston cston modified the milestones: 17.4, Compiler.Next Sep 7, 2022
@AlekseyTs AlekseyTs mentioned this issue Sep 7, 2022
Merged
AlekseyTs added a commit that referenced this issue Sep 12, 2022
@AlekseyTs
Propagate EffectiveScope to parameters of anonymous delegate types. (#…
d960d03 
…63787)

Fixes #63565.
Closes #63078.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cston cston

Labels
Area-Compilers Concept-Continuous Improvement Feature - Ref Fields
Projects
None yet
Milestone
Compiler.Next
Development

Successfully merging a pull request may close this issue.

Propagate EffectiveScope to parameters of anonymous delegate types. AlekseyTs/roslyn
2 participants
@cston @jcouv