Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeGenerator.TryEmitReadonlySpanAsBlobWrapper - doesn't record dependencies from UseSiteInfo for utilized well known methods #61631

Closed
AlekseyTs opened this issue Jun 1, 2022 · 0 comments · Fixed by #65320
Closed

CodeGenerator.TryEmitReadonlySpanAsBlobWrapper - doesn't record dependencies from UseSiteInfo for utilized well known methods #61631

AlekseyTs opened this issue Jun 1, 2022 · 0 comments · Fixed by #65320
Assignees
@AlekseyTs
Labels
Area-Compilers
Milestone
Compiler.Next

Comments

@AlekseyTs
Copy link
Contributor

We should consider:

  • Switching to using Binder.GetWellKnownTypeMember helper that takes BindingDiagnosticBag and take cares of both validating the member and recording the dependencies.
  • Restructure the code so that helpers are looked up only if definitely going to be used (dependencies shouldn't be recorded if a helper isn't used).
  • Audit other places where emit layer uses well known/special members.
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Jun 1, 2022
@jcouv jcouv added this to the Compiler.Next milestone Jun 3, 2022
@jcouv jcouv removed the untriaged Issues and PRs which have not yet been triaged by a lead label Jun 3, 2022
@AlekseyTs AlekseyTs self-assigned this Sep 30, 2022
AlekseyTs added a commit to AlekseyTs/roslyn that referenced this issue Nov 9, 2022
@AlekseyTs
Ensure emit layer doesn't ignore diagnostics and dependencies for wel…
496d072 
…l known members.

Closes dotnet#61631.
@AlekseyTs AlekseyTs mentioned this issue Nov 9, 2022
Merged
@AlekseyTs AlekseyTs moved this to In Progress in Roslyn Compiler Tech Debt Nov 9, 2022
AlekseyTs added a commit that referenced this issue Nov 15, 2022
@AlekseyTs
Ensure emit layer doesn't ignore diagnostics and dependencies for wel…
9c28d50 
…l known members. (#65320)

Closes #61631.
Repository owner moved this from In Progress to Done in Roslyn Compiler Tech Debt Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlekseyTs AlekseyTs

Labels
Area-Compilers
Projects
Roslyn Compiler Tech Debt
Status: Done
Milestone
Compiler.Next
2 participants
@AlekseyTs @jcouv