Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It looks like Microsoft.CodeAnalysis.MSBuild.UnitTests.MSBuildWorkspaceTests.TestOpenProject_AssemblyNameIsPath unit-test is flaky #50258

Closed
AlekseyTs opened this issue Jan 5, 2021 · 2 comments · Fixed by #50619
Assignees
Labels
Area-IDE Flaky IDE-MSBuildWorkspace MSBuildWorkspace Test Test failures in roslyn-CI
Milestone

Comments

@AlekseyTs
Copy link
Contributor

Lately, I am consistently getting the test failure when run it on my dev box. Both from command line and from VS:

Microsoft.CodeAnalysis.MSBuild.UnitTests.MSBuildWorkspaceTests.TestOpenProject_AssemblyNameIsPath [FAIL]
  Assert.Equal() Failure
                                   ↓ (pos 50)
  Expected: ···l\Temp\2\RoslynTests
  Actual:   ···l\Temp\2\RoslynTests\fc082681-b2ee-4795-a7b1-cda1d73c7e31\CSh···
                                   ↑ (pos 50)
  Stack Trace:
    F:\GitHub\roslyn\src\Workspaces\MSBuildTest\MSBuildWorkspaceTests.cs(830,0): at Microsoft.CodeAnalysis.MSBuild.UnitTests.MSBuildWorkspaceTests.<TestOpenProject_AssemblyNameIsPath>d__40.MoveNext()
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    --- End of stack trace from previous location where exception was thrown ---
       at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

The guid is different from run to run.
However, CI for a GitHub PR is passing.

@AlekseyTs AlekseyTs added Test Test failures in roslyn-CI IDE-MSBuildWorkspace MSBuildWorkspace labels Jan 5, 2021
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 5, 2021
@jinujoseph jinujoseph added Flaky and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 5, 2021
@jinujoseph jinujoseph added this to the 16.9 milestone Jan 5, 2021
jmarolf added a commit to jmarolf/roslyn that referenced this issue Jan 19, 2021
@jmarolf jmarolf modified the milestones: 16.9, Backlog Jan 21, 2021
@JoeRobich
Copy link
Member

This issue causes the Roslyn integration tests to fail on the 16.9 Preview 3 scouting image - https://dev.azure.com/dnceng/public/_build/results?buildId=969374&view=ms.vss-test-web.build-test-results-tab&runId=30470034&resultId=100039&paneView=debug

@JoeRobich
Copy link
Member

This was caused by a MSBuild change where they will infer an OutputPath when one is not specified. See dotnet/msbuild#5238

@ghost ghost closed this as completed in #50619 Feb 4, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Flaky IDE-MSBuildWorkspace MSBuildWorkspace Test Test failures in roslyn-CI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants