Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash in is operator used with tuple #19310

Closed
gafter opened this issue May 5, 2017 · 0 comments · Fixed by #19413
Closed

Crash in is operator used with tuple #19310

gafter opened this issue May 5, 2017 · 0 comments · Fixed by #19413
Assignees
@gafter
Labels
Area-Compilers Bug Feature - Tuples Tuples
Milestone
15.3

Comments

@gafter
Copy link
Member

gafter commented May 5, 2017

Version Used:

VS2015 most recent update

Steps to Reproduce:

  1. Type the following statements
var x = (1, 2);
if (x is ValueTuple<long, long>) { }

Expected Behavior:

Compiler reports "warning, the given expression is never of the provided (long, long) type."

Actual Behavior:

Visual Studio crashes.
@gafter gafter added this to the 15.3 milestone May 5, 2017
@gafter gafter self-assigned this May 5, 2017
gafter added a commit to gafter/roslyn that referenced this issue May 9, 2017
@gafter
Refactor subsumption implementation.
bdb5311 
Fixes dotnet#19310
Fixes dotnet#19273
Fixes dotnet#19151
gafter added a commit to gafter/roslyn that referenced this issue May 9, 2017
@gafter
Refactor subsumption implementation.
98f6d70 
    Fixes dotnet#19310
    Fixes dotnet#19273
    Fixes dotnet#19151
gafter added a commit to gafter/roslyn that referenced this issue May 10, 2017
@gafter
Refactor subsumption implementation
972bb38 
* Fixes crash in `is` operator used with tuples
Fixes dotnet#19310

* Unify subsumption implementations
Fixes dotnet#19273

* Matching an expression of type `byte?` with a pattern of type `int` should not be allowed
Fixes dotnet#19151

* Add documentation for the breaking change matching `int?` against the pattern `long x`
@gafter gafter added the 4 - In Review A fix for the issue is submitted for review. label May 10, 2017
@gafter gafter mentioned this issue May 10, 2017
Merged
gafter added a commit that referenced this issue May 19, 2017
@gafter
Fix crash in is operator used with tuples (#19413)
b057348 
* Fixes crash in `is` operator used with tuples
Fixes #19310

* Matching an expression of type `byte?` with a pattern of type `int` should not be allowed
* Add documentation for the breaking change matching `int?` against the pattern `long x`
Fixes #19151

* Unify subsumption implementations
Fixes #19273

* Greatly improved code gen for value type pattern match
Fixes #16129
Fixes #18944
Fixes #14252

* Add test confirming that #19122 is fixed.
Fixes #19122
@gafter gafter removed the 4 - In Review A fix for the issue is submitted for review. label May 19, 2017
@jcouv jcouv mentioned this issue May 20, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gafter gafter

Labels
Area-Compilers Bug Feature - Tuples Tuples
Projects
None yet
Milestone
15.3
Development

Successfully merging a pull request may close this issue.

Fix crash in is operator used with tuples gafter/roslyn
1 participant
@gafter