Merge pull request #63930 from CyrusNajmabadi/testConsistency2

Use attributes consistently in tests.
dotnet · Sep 12, 2022 · 6729a11 · 6729a11
2 parents b2bbe29 + e1acd90
commit 6729a11
Show file tree

Hide file tree

Showing 492 changed files with 6,039 additions and 12,055 deletions.
diff --git a/src/Analyzers/CSharp/Tests/AddAccessibilityModifiers/AddAccessibilityModifiersTests.cs b/src/Analyzers/CSharp/Tests/AddAccessibilityModifiers/AddAccessibilityModifiersTests.cs
@@ -485,8 +485,7 @@ internal class Program
 ");
         }
 
-        [WorkItem(48899, "https://github.com/dotnet/roslyn/issues/48899")]
-        [Fact]
+        [Fact, WorkItem(48899, "https://github.com/dotnet/roslyn/issues/48899")]
         public async Task TestAbstractMethod()
         {
             await VerifyCS.VerifyCodeFixAsync(@"
@@ -503,8 +502,7 @@ public abstract class TestClass
 ");
         }
 
-        [WorkItem(48899, "https://github.com/dotnet/roslyn/issues/48899")]
-        [Fact]
+        [Fact, WorkItem(48899, "https://github.com/dotnet/roslyn/issues/48899")]
         public async Task TestOverriddenMethod()
         {
             await VerifyCS.VerifyCodeFixAsync(@"
@@ -550,8 +548,7 @@ internal struct S1 { }
             }.RunAsync();
         }
 
-        [Fact]
-        [WorkItem(55703, "https://github.com/dotnet/roslyn/issues/55703")]
+        [Fact, WorkItem(55703, "https://github.com/dotnet/roslyn/issues/55703")]
         public async Task TestPartial_WithExistingModifier()
         {
             var source = @"
@@ -583,8 +580,7 @@ public partial class C
             await test.RunAsync();
         }
 
-        [Fact]
-        [WorkItem(58914, "https://github.com/dotnet/roslyn/issues/58914")]
+        [Fact, WorkItem(58914, "https://github.com/dotnet/roslyn/issues/58914")]
         public async Task TestStaticOperatorInInterface()
         {
             var source = @"
@@ -633,8 +629,7 @@ public async Task TestFileDeclaration(string declarationKind)
             }.RunAsync();
         }
 
-        [Fact]
-        [WorkItem(62259, "https://github.com/dotnet/roslyn/issues/62259")]
+        [Fact, WorkItem(62259, "https://github.com/dotnet/roslyn/issues/62259")]
         public async Task TestFileDelegate()
         {
             var source = "file delegate void M();";

diff --git a/src/Analyzers/CSharp/Tests/AddBraces/AddBracesTests.cs b/src/Analyzers/CSharp/Tests/AddBraces/AddBracesTests.cs
@@ -359,8 +359,7 @@ static void Main()
                 expectDiagnostic);
         }
 
-        [WorkItem(57770, "https://github.com/dotnet/roslyn/issues/57770")]
-        [Theory]
+        [Theory, WorkItem(57770, "https://github.com/dotnet/roslyn/issues/57770")]
         [InlineData((int)PreferBracesPreference.None, false)]
         [InlineData((int)PreferBracesPreference.WhenMultiline, false)]
         [InlineData((int)PreferBracesPreference.Always, true)]

diff --git a/src/Analyzers/CSharp/Tests/AddExplicitCast/AddExplicitCastTests.cs b/src/Analyzers/CSharp/Tests/AddExplicitCast/AddExplicitCastTests.cs
@@ -3053,8 +3053,7 @@ void M()
 }");
         }
 
-        [Fact]
-        [WorkItem(50493, "https://github.com/dotnet/roslyn/issues/50493")]
+        [Fact, WorkItem(50493, "https://github.com/dotnet/roslyn/issues/50493")]
         public async Task ArrayAccess()
         {
             await TestInRegularAndScriptAsync(

diff --git a/src/Analyzers/CSharp/Tests/ConvertNamespace/ConvertToFileScopedNamespaceAnalyzerTests.cs b/src/Analyzers/CSharp/Tests/ConvertNamespace/ConvertToFileScopedNamespaceAnalyzerTests.cs
@@ -815,8 +815,7 @@ class C { }
             }.RunAsync();
         }
 
-        [Fact]
-        [WorkItem(59728, "https://github.com/dotnet/roslyn/issues/59728")]
+        [Fact, WorkItem(59728, "https://github.com/dotnet/roslyn/issues/59728")]
         public async Task TestConvertToFileScopedWithNoNewlineAtEnd()
         {
             await new VerifyCS.Test
@@ -842,8 +841,7 @@ class C
             }.RunAsync();
         }
 
-        [Fact]
-        [WorkItem(59728, "https://github.com/dotnet/roslyn/issues/59728")]
+        [Fact, WorkItem(59728, "https://github.com/dotnet/roslyn/issues/59728")]
         public async Task TestConvertToFileScopedWithNoMembersAndNoNewlineAtEnd()
         {
             await new VerifyCS.Test
@@ -862,8 +860,7 @@ namespace $$N;",
             }.RunAsync();
         }
 
-        [Fact]
-        [WorkItem(59728, "https://github.com/dotnet/roslyn/issues/59728")]
+        [Fact, WorkItem(59728, "https://github.com/dotnet/roslyn/issues/59728")]
         public async Task TestConvertToFileScopedPreserveNewlineAtEnd()
         {
             await new VerifyCS.Test
@@ -891,8 +888,7 @@ class C
             }.RunAsync();
         }
 
-        [Fact]
-        [WorkItem(59728, "https://github.com/dotnet/roslyn/issues/59728")]
+        [Fact, WorkItem(59728, "https://github.com/dotnet/roslyn/issues/59728")]
         public async Task TestConvertToFileScopedWithNoMembersPreserveNewlineAtEnd()
         {
             await new VerifyCS.Test

diff --git a/...Tests/ConvertSwitchStatementToExpression/ConvertSwitchStatementToExpressionFixAllTests.cs b/...Tests/ConvertSwitchStatementToExpression/ConvertSwitchStatementToExpressionFixAllTests.cs
@@ -215,8 +215,7 @@ System.Func<int> M(int i, int j)
             }.RunAsync();
         }
 
-        [WorkItem(37907, "https://github.com/dotnet/roslyn/issues/37907")]
-        [Fact]
+        [Fact, WorkItem(37907, "https://github.com/dotnet/roslyn/issues/37907")]
         public async Task TestNested_03()
         {
             await VerifyCS.VerifyCodeFixAsync(
@@ -274,8 +273,7 @@ public bool ValueBoolean()
     }
 }");
         }
-        [WorkItem(44572, "https://github.com/dotnet/roslyn/issues/44572")]
-        [Fact]
+        [Fact, WorkItem(44572, "https://github.com/dotnet/roslyn/issues/44572")]
         public async Task TestImplicitConversion()
         {
             await VerifyCS.VerifyCodeFixAsync(