Resolve follow-up comments in PR "Create default arguments during bin…

…ding" (#49588)
dotnet · Nov 24, 2020 · 1f97e38 · 1f97e38
1 parent 88aca6f
commit 1f97e38
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 12 deletions.
diff --git a/src/Compilers/CSharp/Portable/Binder/Binder_Invocation.cs b/src/Compilers/CSharp/Portable/Binder/Binder_Invocation.cs
@@ -1186,7 +1186,7 @@ internal BoundExpression BindDefaultArgument(SyntaxNode syntax, ParameterSymbol
             BoundExpression defaultValue;
             if (callerSourceLocation is object && parameter.IsCallerLineNumber)
             {
-                int line = GetCallerLocation(syntax).SourceTree.GetDisplayLineNumber(callerSourceLocation.SourceSpan);
+                int line = callerSourceLocation.SourceTree.GetDisplayLineNumber(callerSourceLocation.SourceSpan);
                 defaultValue = new BoundLiteral(syntax, ConstantValue.Create(line), Compilation.GetSpecialType(SpecialType.System_Int32)) { WasCompilerGenerated = true };
             }
             else if (callerSourceLocation is object && parameter.IsCallerFilePath)

diff --git a/src/Compilers/CSharp/Portable/Symbols/Source/SourceComplexParameterSymbol.cs b/src/Compilers/CSharp/Portable/Symbols/Source/SourceComplexParameterSymbol.cs
@@ -224,17 +224,7 @@ private ConstantValue DefaultSyntaxValue
                     Debug.Assert(completedOnThisThread);
                 }
 
-#if DEBUG
-                // If we accidentally access DefaultSyntaxValue in a reentrant manner, and we use a cancellation token
-                // that never expires, then the failure mode will be to spin wait forever.
-                // For debug purposes let's instead use a token which expires after a modest amount of time
-                // to wait for the default syntax value to be available.
-                var cts = new CancellationTokenSource(TimeSpan.FromSeconds(5));
-                var token = cts.Token;
-#else
-                var token = CancellationToken.None;
-#endif
-                state.SpinWaitComplete(CompletionPart.EndDefaultSyntaxValue, token);
+                state.SpinWaitComplete(CompletionPart.EndDefaultSyntaxValue, default(CancellationToken));
                 return _lazyDefaultSyntaxValue;
             }
         }