Add regression test for attribute with async delegate parameter (#30969)

* Add regression test for attribute consuming async Task-returning delegate * Add corresponding VB test
dotnet · Nov 6, 2018 · 1abe965 · 1abe965
1 parent 2468ad7
commit 1abe965
Show file tree

Hide file tree

Showing 2 changed files with 72 additions and 0 deletions.
diff --git a/src/Compilers/CSharp/Test/Emit/Attributes/AttributeTests.cs b/src/Compilers/CSharp/Test/Emit/Attributes/AttributeTests.cs
@@ -8913,6 +8913,44 @@ internal sealed class CSharpCompilerDiagnosticAnalyzer
                 );
         }
 
+        [Fact, WorkItem(30833, "https://github.com/dotnet/roslyn/issues/30833")]
+        public void AttributeWithTaskDelegateParameter()
+        {
+            string code = @"
+using System;
+using System.Threading.Tasks;
+
+namespace a
+{
+    class Class1
+    {
+		[AttributeUsage(AttributeTargets.Class, AllowMultiple = true)]
+		class CommandAttribute : Attribute
+		{
+			public delegate Task FxCommand();
+
+			public CommandAttribute(FxCommand Fx)
+			{
+				this.Fx = Fx;
+			}
+
+			public FxCommand Fx { get; set; }
+		}
+		
+		[Command(UserInfo)]
+		public static async Task UserInfo()
+		{
+			await Task.CompletedTask;
+		}
+	}
+}
+";
+            CreateCompilationWithMscorlib46(code).VerifyDiagnostics(
+                // (22,4): error CS0181: Attribute constructor parameter 'Fx' has type 'Class1.CommandAttribute.FxCommand', which is not a valid attribute parameter type
+                // 		[Command(UserInfo)]
+                Diagnostic(ErrorCode.ERR_BadAttributeParamType, "Command").WithArguments("Fx", "a.Class1.CommandAttribute.FxCommand").WithLocation(22, 4));
+        }
+
         #endregion
     }
 }
diff --git a/src/Compilers/VisualBasic/Test/Emit/Attributes/AttributeTests.vb b/src/Compilers/VisualBasic/Test/Emit/Attributes/AttributeTests.vb
@@ -4618,5 +4618,39 @@ End Class
             Assert.NotNull(compilation2.GetTypeByMetadataName("TestReference2"))
         End Sub
 
+        <Fact>
+        Public Sub AttributeWithTaskDelegateParameter()
+            Dim code = "
+Imports System
+Imports System.Threading.Tasks
+
+Namespace a
+    Public Class Class1
+        <AttributeUsage(AttributeTargets.Class, AllowMultiple:=True)>
+        Public Class CommandAttribute
+            Inherits Attribute
+
+            Public Delegate Function FxCommand() As Task
+
+            Public Sub New(Fx As FxCommand)
+                Me.Fx = Fx
+            End Sub
+
+            Public Property Fx As FxCommand
+        End Class
+
+        <Command(AddressOf UserInfo)>
+        Public Shared Async Function UserInfo() As Task
+            Await New Task(
+                Sub()
+                End Sub)
+        End Function
+    End Class
+End Namespace
+"
+            CreateCompilationWithMscorlib45(code).VerifyDiagnostics(
+                Diagnostic(ERRID.ERR_BadAttributeConstructor1, "Command").WithArguments("a.Class1.CommandAttribute.FxCommand").WithLocation(20, 10),
+                Diagnostic(ERRID.ERR_RequiredConstExpr, "AddressOf UserInfo").WithLocation(20, 18))
+        End Sub
     End Class
 End Namespace