Skip to content

Commit

Permalink
Use the singular form in some analyzer titles
Browse files Browse the repository at this point in the history
  • Loading branch information
CyrusNajmabadi committed Oct 26, 2022
1 parent 4786ca0 commit 04cf40b
Show file tree
Hide file tree
Showing 23 changed files with 756 additions and 756 deletions.
72 changes: 36 additions & 36 deletions src/Analyzers/CSharp/Analyzers/CSharpAnalyzersResources.resx
Original file line number Diff line number Diff line change
Expand Up @@ -164,53 +164,53 @@
<value>Warning: Moving using directives may change code meaning.</value>
<comment>{Locked="using"} "using" is a C# keyword and should not be localized.</comment>
</data>
<data name="Use_expression_body_for_methods" xml:space="preserve">
<value>Use expression body for methods</value>
<data name="Use_expression_body_for_method" xml:space="preserve">
<value>Use expression body for method</value>
</data>
<data name="Use_block_body_for_methods" xml:space="preserve">
<value>Use block body for methods</value>
<data name="Use_block_body_for_method" xml:space="preserve">
<value>Use block body for method</value>
</data>
<data name="Use_block_body_for_accessors" xml:space="preserve">
<value>Use block body for accessors</value>
<data name="Use_block_body_for_accessor" xml:space="preserve">
<value>Use block body for accessor</value>
</data>
<data name="Use_block_body_for_constructors" xml:space="preserve">
<value>Use block body for constructors</value>
<data name="Use_block_body_for_constructor" xml:space="preserve">
<value>Use block body for constructor</value>
</data>
<data name="Use_block_body_for_indexers" xml:space="preserve">
<value>Use block body for indexers</value>
<data name="Use_block_body_for_indexer" xml:space="preserve">
<value>Use block body for indexer</value>
</data>
<data name="Use_block_body_for_operators" xml:space="preserve">
<value>Use block body for operators</value>
<data name="Use_block_body_for_operator" xml:space="preserve">
<value>Use block body for operator</value>
</data>
<data name="Use_block_body_for_conversion_operators" xml:space="preserve">
<value>Use block body for conversion operators</value>
<data name="Use_block_body_for_conversion_operator" xml:space="preserve">
<value>Use block body for conversion operator</value>
</data>
<data name="Use_block_body_for_properties" xml:space="preserve">
<value>Use block body for properties</value>
<data name="Use_block_body_for_property" xml:space="preserve">
<value>Use block body for property</value>
</data>
<data name="Use_expression_body_for_accessors" xml:space="preserve">
<value>Use expression body for accessors</value>
<data name="Use_expression_body_for_accessor" xml:space="preserve">
<value>Use expression body for accessor</value>
</data>
<data name="Use_expression_body_for_constructors" xml:space="preserve">
<value>Use expression body for constructors</value>
<data name="Use_expression_body_for_constructor" xml:space="preserve">
<value>Use expression body for constructor</value>
</data>
<data name="Use_expression_body_for_indexers" xml:space="preserve">
<value>Use expression body for indexers</value>
<data name="Use_expression_body_for_indexer" xml:space="preserve">
<value>Use expression body for indexer</value>
</data>
<data name="Use_expression_body_for_operators" xml:space="preserve">
<value>Use expression body for operators</value>
<data name="Use_expression_body_for_operator" xml:space="preserve">
<value>Use expression body for operator</value>
</data>
<data name="Use_expression_body_for_conversion_operators" xml:space="preserve">
<value>Use expression body for conversion operators</value>
<data name="Use_expression_body_for_conversion_operator" xml:space="preserve">
<value>Use expression body for conversion operator</value>
</data>
<data name="Use_expression_body_for_properties" xml:space="preserve">
<value>Use expression body for properties</value>
<data name="Use_expression_body_for_property" xml:space="preserve">
<value>Use expression body for property</value>
</data>
<data name="Use_block_body_for_local_functions" xml:space="preserve">
<value>Use block body for local functions</value>
<data name="Use_block_body_for_local_function" xml:space="preserve">
<value>Use block body for local function</value>
</data>
<data name="Use_expression_body_for_local_functions" xml:space="preserve">
<value>Use expression body for local functions</value>
<data name="Use_expression_body_for_local_function" xml:space="preserve">
<value>Use expression body for local function</value>
</data>
<data name="Unreachable_code_detected" xml:space="preserve">
<value>Unreachable code detected</value>
Expand Down Expand Up @@ -383,11 +383,11 @@
<data name="Remove_redundant_nullable_directive" xml:space="preserve">
<value>Remove redundant nullable directive</value>
</data>
<data name="Use_expression_body_for_lambda_expressions" xml:space="preserve">
<value>Use expression body for lambda expressions</value>
<data name="Use_expression_body_for_lambda_expression" xml:space="preserve">
<value>Use expression body for lambda expression</value>
</data>
<data name="Use_block_body_for_lambda_expressions" xml:space="preserve">
<value>Use block body for lambda expressions</value>
<data name="Use_block_body_for_lambda_expression" xml:space="preserve">
<value>Use block body for lambda expression</value>
</data>
<data name="Make_struct_readonly" xml:space="preserve">
<value>Make struct 'readonly'</value>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ internal class UseExpressionBodyForAccessorsHelper :
private UseExpressionBodyForAccessorsHelper()
: base(IDEDiagnosticIds.UseExpressionBodyForAccessorsDiagnosticId,
EnforceOnBuildValues.UseExpressionBodyForAccessors,
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_expression_body_for_accessors), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_block_body_for_accessors), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_expression_body_for_accessor), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_block_body_for_accessor), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
CSharpCodeStyleOptions.PreferExpressionBodiedAccessors,
ImmutableArray.Create(SyntaxKind.GetAccessorDeclaration, SyntaxKind.SetAccessorDeclaration, SyntaxKind.InitAccessorDeclaration, SyntaxKind.AddAccessorDeclaration, SyntaxKind.RemoveAccessorDeclaration))
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ internal class UseExpressionBodyForConstructorsHelper :
private UseExpressionBodyForConstructorsHelper()
: base(IDEDiagnosticIds.UseExpressionBodyForConstructorsDiagnosticId,
EnforceOnBuildValues.UseExpressionBodyForConstructors,
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_expression_body_for_constructors), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_block_body_for_constructors), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_expression_body_for_constructor), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_block_body_for_constructor), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
CSharpCodeStyleOptions.PreferExpressionBodiedConstructors,
ImmutableArray.Create(SyntaxKind.ConstructorDeclaration))
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ internal class UseExpressionBodyForConversionOperatorsHelper :
private UseExpressionBodyForConversionOperatorsHelper()
: base(IDEDiagnosticIds.UseExpressionBodyForConversionOperatorsDiagnosticId,
EnforceOnBuildValues.UseExpressionBodyForConversionOperators,
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_expression_body_for_conversion_operators), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_block_body_for_conversion_operators), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_expression_body_for_conversion_operator), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_block_body_for_conversion_operator), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
CSharpCodeStyleOptions.PreferExpressionBodiedOperators,
ImmutableArray.Create(SyntaxKind.ConversionOperatorDeclaration))
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ internal class UseExpressionBodyForIndexersHelper :
private UseExpressionBodyForIndexersHelper()
: base(IDEDiagnosticIds.UseExpressionBodyForIndexersDiagnosticId,
EnforceOnBuildValues.UseExpressionBodyForIndexers,
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_expression_body_for_indexers), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_block_body_for_indexers), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_expression_body_for_indexer), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_block_body_for_indexer), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
CSharpCodeStyleOptions.PreferExpressionBodiedIndexers,
ImmutableArray.Create(SyntaxKind.IndexerDeclaration))
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ internal class UseExpressionBodyForLocalFunctionHelper :
private UseExpressionBodyForLocalFunctionHelper()
: base(IDEDiagnosticIds.UseExpressionBodyForLocalFunctionsDiagnosticId,
EnforceOnBuildValues.UseExpressionBodyForLocalFunctions,
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_expression_body_for_local_functions), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_block_body_for_local_functions), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_expression_body_for_local_function), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_block_body_for_local_function), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
CSharpCodeStyleOptions.PreferExpressionBodiedLocalFunctions,
ImmutableArray.Create(SyntaxKind.LocalFunctionStatement))
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ internal class UseExpressionBodyForMethodsHelper :
private UseExpressionBodyForMethodsHelper()
: base(IDEDiagnosticIds.UseExpressionBodyForMethodsDiagnosticId,
EnforceOnBuildValues.UseExpressionBodyForMethods,
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_expression_body_for_methods), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_block_body_for_methods), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_expression_body_for_method), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_block_body_for_method), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
CSharpCodeStyleOptions.PreferExpressionBodiedMethods,
ImmutableArray.Create(SyntaxKind.MethodDeclaration))
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ internal class UseExpressionBodyForOperatorsHelper :
private UseExpressionBodyForOperatorsHelper()
: base(IDEDiagnosticIds.UseExpressionBodyForOperatorsDiagnosticId,
EnforceOnBuildValues.UseExpressionBodyForOperators,
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_expression_body_for_operators), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_block_body_for_operators), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_expression_body_for_operator), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_block_body_for_operator), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
CSharpCodeStyleOptions.PreferExpressionBodiedOperators,
ImmutableArray.Create(SyntaxKind.OperatorDeclaration))
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ internal class UseExpressionBodyForPropertiesHelper :
private UseExpressionBodyForPropertiesHelper()
: base(IDEDiagnosticIds.UseExpressionBodyForPropertiesDiagnosticId,
EnforceOnBuildValues.UseExpressionBodyForProperties,
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_expression_body_for_properties), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_block_body_for_properties), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_expression_body_for_property), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_block_body_for_property), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources)),
CSharpCodeStyleOptions.PreferExpressionBodiedProperties,
ImmutableArray.Create(SyntaxKind.PropertyDeclaration))
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ namespace Microsoft.CodeAnalysis.CSharp.UseExpressionBodyForLambda
{
internal static class UseExpressionBodyForLambdaHelpers
{
internal static readonly LocalizableString UseExpressionBodyTitle = new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_expression_body_for_lambda_expressions), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources));
internal static readonly LocalizableString UseBlockBodyTitle = new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_block_body_for_lambda_expressions), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources));
internal static readonly LocalizableString UseExpressionBodyTitle = new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_expression_body_for_lambda_expression), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources));
internal static readonly LocalizableString UseBlockBodyTitle = new LocalizableResourceString(nameof(CSharpAnalyzersResources.Use_block_body_for_lambda_expression), CSharpAnalyzersResources.ResourceManager, typeof(CSharpAnalyzersResources));

internal static bool CanOfferUseBlockBody(
SemanticModel semanticModel, ExpressionBodyPreference preference,
Expand Down
Loading

0 comments on commit 04cf40b

Please sign in to comment.