Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherry pick "Enabled logging analyzer on new repo" #5322

Merged
merged 45 commits into from
Jul 29, 2021
Merged

cherry pick "Enabled logging analyzer on new repo" #5322

merged 45 commits into from
Jul 29, 2021

Conversation

jmarolf
Copy link
Contributor

@jmarolf jmarolf commented Jul 28, 2021 •
edited
Loading

cherry-pick of #5244

xtqqczze and others added 30 commits July 19, 2021 15:43
@xtqqczze
Delete IDE dispose analyzer rules
82a5b7e 
The IDE dispose analyzer rules have been deleted from Roslyn:

dotnet/roslyn@eeba499
@RikkiGibson
Remove dead code in CA1069 analyzer (dotnet#5253)
af5cc6f
@mavasani
Merge pull request dotnet#5255 from xtqqczze/patch-1
8ca2a79 
Delete IDE dispose analyzer rules from .editorconfig
@brianaeng
Initial add of richnav indexing
0b0fd2c
@brianaeng
Update yml spacing
ef83248
@brianaeng
Remove unauthorized settings
dd83d4b
@brianaeng
Update pool
a059cd9
@Evangelink
Remove some empty statements
0296b4a
@brianaeng
Attempt to fix test step in build pipeline
39ca864
@brianaeng
Add richnav nuget source
4ad3a61
@brianaeng
RichNav run worked in main yml -- removing from there and copying it …
c0fbdbf 
…to richnav solo yml
@brianaeng
Remove added whitespace
2ef6f11
@brianaeng
Remove unused vars, rename displayName for clarity
50e3c65
@sharwell
Merge pull request dotnet#5278 from Evangelink/empty-statements
2945bf8 
Remove some empty statements
@jmarolf
Merge pull request dotnet#5267 from brianaeng/breng/addRichNav
75d0251
Merge pull request dotnet#5258 from dotnet/merges/main-to-release/6.0…
19af447 
….1xx

Merge main to release/6.0.1xx
Fix TODOs and update unit tests with diagnostics (dotnet#5287)
d36599d 
* Fix TODOs and update unit tests with diagnostics

* Address comments

* sq

* Address feedback
@maryamariyan
Add Logging Analyzer
12a3544
@maryamariyan
Convert to IOperation analysis
6c5e4ad
@maryamariyan
Updated tests based on refactor
a45c883
@maryamariyan
minor code cleanup
3892a17
@maryamariyan
PR feedback
e86185d
@maryamariyan
Use CreateDiagnostic extension method
3479c9f
@maryamariyan
update auto generated files
c9d0820
@maryamariyan
Fix "Run markdownlint" error
2b3cc77
@maryamariyan
isPortedFxCopRule set false by default
ebed92d
@maryamariyan
isReportedAtCompilationEnd set to false
6dba133
@sharwell @maryamariyan
Rename test class to match file name
2e85d6d
@sharwell @maryamariyan
Update INameOfOperation handling to use correct constant value
fbb89d5
@sharwell @maryamariyan
Update IOperation to understand params arguments
41a7fd9
maryamariyan and others added 14 commits July 27, 2021 18:07
@maryamariyan
move analyzer from csharp to core
d7e7ee3
@maryamariyan
Apply API review feedback.
63bf4c4 
- Switch category to Reliability for fifth diagnostic
- Switch severity to hidden from disabled for first two
@maryamariyan
narrow down scope of 4th diagnostic to LogTrace and friends
7c668b7
@maryamariyan
updating messages to become a bit more clear
88ed19a
@maryamariyan
Apply nit feedback
0e517e5
@maryamariyan
nit feedback
24f5bfb
@maryamariyan
if to else if
87443d4
Merge pull request dotnet#5294 from dotnet/merges/main-to-release/6.0…
3363fbe 
….1xx

Merge main to release/6.0.1xx
@maryamariyan
rename: named hole -> named placeholder
0c84b59
@maryamariyan
fix paranthesis issue
cf7cc42
@jmarolf
Merge remote-tracking branch 'upstream/release/6.0.1xx-preview7' into…
2721158 
… merges/release/6.0.1xx-preview7-to-release/6.0.1xx
@jmarolf
do not update the label
c19648e
@jmarolf
Merge pull request dotnet#5244 from maryamariyan/logging-az
7445fb3
Merge pull request dotnet#5293 from dotnet/merges/release/6.0.1xx-pre…
92cc133 
…view7-to-release/6.0.1xx

Merge release/6.0.1xx-preview7 to release/6.0.1xx
@jmarolf jmarolf requested a review from a team as a code owner July 28, 2021 22:09
@jmarolf jmarolf changed the base branch from main to release/6.0.1xx-preview7 July 28, 2021 22:09
@jmarolf jmarolf changed the title cherry pick/logging analyzer cherry pick "Enabled logging analyzer on new repo" Jul 28, 2021
@jmarolf jmarolf force-pushed the cherry-pick/logging-analyzer branch from 4463447 to fa1323a Compare July 28, 2021 22:29
@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #5322 (fa1323a) into release/6.0.1xx-preview7 (bfc0bea) will decrease coverage by 0.00%.
The diff coverage is 91.39%.

@@                     Coverage Diff                      @@
##           release/6.0.1xx-preview7    #5322      +/-   ##
============================================================
- Coverage                     95.61%   95.60%   -0.01%     
============================================================
  Files                          1233     1236       +3     
  Lines                        283396   283895     +499     
  Branches                      16972    17032      +60     
============================================================
+ Hits                         270956   271416     +460     
- Misses                        10162    10179      +17     
- Partials                       2278     2300      +22

@jmarolf jmarolf merged commit 02e99f1 into dotnet:release/6.0.1xx-preview7 Jul 29, 2021
@jmarolf jmarolf deleted the cherry-pick/logging-analyzer branch July 29, 2021 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jmarolf @xtqqczze @RikkiGibson @mavasani @brianaeng @Evangelink @sharwell @dotnet-bot @maryamariyan