Delete test which is unrelated to the analyzer of interest #4853
Conversation
| [Fact, WorkItem(1671, "https://github.com/dotnet/roslyn-analyzers/issues/1671")] | ||
| public async Task ErrorCase_NoDiagnostic() | ||
| { | ||
| // Missing "using System;" causes "Equals" method be marked as IsOverride but with null OverriddenMethod. |
There was a problem hiding this comment.
This comment makes me think that this case used to cause a crash.
There was a problem hiding this comment.
Most likely, this tests the following code path:
There was a problem hiding this comment.
This comment makes me think that this case used to cause a crash
It may have, but not in this analyzer.
Most likely, this tests the following code path:
We have other tests covering the same path (all tests that contain methods not marked override).
Codecov Report
@@ Coverage Diff @@
## master #4853 +/- ##
===========================================
+ Coverage 0 95.62% +95.62%
===========================================
Files 0 1177 +1177
Lines 0 269379 +269379
Branches 0 16258 +16258
===========================================
+ Hits 0 257600 +257600
- Misses 0 9677 +9677
- Partials 0 2102 +2102 |
|
CI failure |
|
Interesting. Looks like that one is a bug in Roslyn; submitted dotnet/roslyn#51244 to fix. |
Closes #4544