PostRelease activities after release of new analyzer packages #4503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also migrated dogfood analyzers from FxCopAnalyzers to NetAnalayzers, with AnalysisMode = AllEnabledByDefault, which enabled additional CA analyzers in the repo. I have fixed/disabled the additional analyzers as appropriate.
mavasani
commented
Dec 5, 2020
Codecov Report
@@ Coverage Diff @@
## master #4503 +/- ##
==========================================
- Coverage 95.84% 95.84% -0.01%
==========================================
Files 1175 1177 +2
Lines 268061 268104 +43
Branches 16177 16181 +4
==========================================
+ Hits 256936 256955 +19
- Misses 9054 9080 +26
+ Partials 2071 2069 -2 |
Evangelink
reviewed
Dec 5, 2020
src/Microsoft.CodeAnalysis.Analyzers/Core/MetaAnalyzers/RegisterActionAnalyzer.cs
Outdated
Show resolved
Hide resolved
...ts/Microsoft.NetCore.Analyzers/Security/DataSetDataTableInWebSerializableObjectGraphTests.cs
Show resolved
Hide resolved
Evangelink
reviewed
Dec 7, 2020
Closed
mavasani
commented
Dec 7, 2020
src/Microsoft.CodeAnalysis.Analyzers/Core/MetaAnalyzers/RegisterActionAnalyzer.cs
Outdated
Show resolved
Hide resolved
|
Thanks for the review @Evangelink - I think I addressed all your feedback. Can you please take another look? |
Evangelink
approved these changes
Dec 7, 2020
|
Thanks @Evangelink! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also migrated dogfood analyzers from FxCopAnalyzers to NetAnalayzers, with AnalysisMode = AllEnabledByDefault, which enabled additional CA analyzers in the repo. I have fixed/disabled the additional analyzers as appropriate.