Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transport Razor.Utilities.Shared and its dependencies #8542

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Transport Razor.Utilities.Shared and its dependencies #8542

merged 3 commits into from
Apr 5, 2023

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented Mar 30, 2023 •
edited
Loading

@jjonescz jjonescz mentioned this pull request Mar 30, 2023
Merged
@jjonescz jjonescz changed the title Transport Razor.Utilities.Shared Transport Razor.Utilities.Shared and its dependencies Mar 31, 2023
@jjonescz jjonescz marked this pull request as ready for review March 31, 2023 10:02
@jjonescz jjonescz requested a review from a team as a code owner March 31, 2023 10:02
@jjonescz
Copy link
Member Author

jjonescz commented Mar 31, 2023 •
edited
Loading

Verified locally that this should fix the errors in SDK:

  1. Ran Microsoft.NET.Sdk.Razor.Tests - seeing the errors.
  2. Packaged Razor: .\eng\common\build.ps1 -restore -build -pack
  3. Added <add key="local" value="C:\razor\artifacts\packages\Debug\NonShipping" /> to SDK's NuGet.config.
  4. Changed the Razor transport package versions to 7.0.0-dev in SDK's eng\Versions.props.
  5. Rebuilt the SDK and re-ran the tests - no errors.

@jjonescz
Copy link
Member Author

jjonescz commented Apr 3, 2023

@dotnet/razor-compiler for a second review

@jjonescz jjonescz merged commit 7db92e7 into dotnet:main Apr 5, 2023
@jjonescz jjonescz deleted the ship-utilities branch April 5, 2023 06:27
@allisonchou allisonchou mentioned this pull request Apr 6, 2023
Closed
@jjonescz jjonescz mentioned this pull request Apr 19, 2023
Merged
This was referenced Apr 26, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DustinCampbell DustinCampbell DustinCampbell approved these changes

@333fred 333fred 333fred approved these changes

@chsienki chsienki chsienki approved these changes

Assignees
No one assigned
Labels
area-infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jjonescz @DustinCampbell @333fred @chsienki