Fix calculation of implicit state for package dependencies #9370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have two ways of detecting whether a dependency is "implicit": via `IsImplicitlyDefined` and `DefiningProjectFullPath` metadata. It turns out we need to consider both evaluation and build metadata when computing whether package dependencies are implicit. Packages incorrectly advertise `IsImplicitlyDefined` as `false` in build data, while its evaluation properties show the `DefiningProjectFullPath` as differing from the project's path. So this change prioritises `DefiningProjectFullPath` over `IsImplicitlyDefined`, to fix the first bug, and includes both evaluation and build properties, to fix the second.
|
With this fix, the scenario in the linked issue now displays correctly:
|
tmeschter
reviewed
Jan 11, 2024
...ctSystem/Tree/Dependencies/Subscriptions/MSBuildDependencies/MSBuildDependencyFactoryBase.cs
Outdated
Show resolved
Hide resolved
tmeschter
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9368
Fixes #9090
We have two ways of detecting whether a dependency is "implicit": via
IsImplicitlyDefinedandDefiningProjectFullPathmetadata.It turns out we need to consider both evaluation and build metadata when computing whether package dependencies are implicit. Packages incorrectly advertise
IsImplicitlyDefinedasfalsein build data, while its evaluation properties show theDefiningProjectFullPathas differing from the project's path. So this change prioritisesDefiningProjectFullPathoverIsImplicitlyDefined, to work around the incorrect value in build data, and includes both evaluation and build properties, to allow reading theDefiningFullPathvalue when processing a build update.Microsoft Reviewers: Open in CodeFlow