Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle incomplete reads in DeflateStream benchmarks #1867

Merged
merged 1 commit into from
Jun 23, 2021
Merged

handle incomplete reads in DeflateStream benchmarks #1867

merged 1 commit into from
Jun 23, 2021

Conversation

adamsitnik
Copy link
Member

I saw DrewScoggins#6594 and realized that it was not an improvement ;)

Method level file Before After
Decompress Optimal TestDocument.pdf 34.13 us 307.8 us
Decompress Optimal alice29.txt 61.43 us 393.4 us
Decompress Optimal sum 64.63 us 117.1 us
Decompress Fastest TestDocument.pdf 34.03 us 303.2 us
Decompress Fastest alice29.txt 63.68 us 449.3 us
Decompress Fastest sum 65.12 us 122.5 us

cc @DrewScoggins dotnet/docs#24649

@adamsitnik adamsitnik requested a review from stephentoub June 23, 2021 15:18
stephentoub
stephentoub approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adamsitnik adamsitnik merged commit ade1c60 into dotnet:main Jun 23, 2021
@adamsitnik adamsitnik deleted the incompleReads branch June 23, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamsitnik @stephentoub