Fix skipping events on resume handshake #9336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
reviewed
Feb 10, 2025
ReubenBond
reviewed
Feb 10, 2025
| await otherStream.OnNextAsync(interestingData); | ||
| } | ||
| // Wait a bit more for the cache to flush some events | ||
| await Task.Delay(StreamInactivityPeriod.Multiply(3)); |
There was a problem hiding this comment.
Eventually, we should consider adding some hooks using DiagnosticListener for testing. Eg, we do something like this in Aspire to make the testing builder work: https://github.com/dotnet/aspire/blob/f2152929373d3f400d495e7e5482c7a6915106f2/src/Aspire.Hosting/DistributedApplicationBuilder.cs#L462-L473
&
https://github.com/dotnet/aspire/blob/f2152929373d3f400d495e7e5482c7a6915106f2/src/Aspire.Hosting.Testing/DistributedApplicationEntryPointInvoker.cs#L184-L189
gfoidl
reviewed
Feb 10, 2025
ReubenBond
approved these changes
Feb 10, 2025
Co-authored-by: Günther Foidl <gue@korporal.at>
a87d2f8 to
3094043
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9299 and #9023
Microsoft Reviewers: Open in CodeFlow