Use collection initializers or expressions #9090
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The second commit catches the cases of The ambiguous API call compilation errors are due to not having the .NET 9 compiler smarts :( |
This is the recommented way and is starting to be applied throughout the dotnet runtime. See dotnet/runtime#105122. Applied code fixes for: - IDE0028: https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0028?pivots=dotnet-8-0 - IDE00300: https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0300
alrz
reviewed
Jul 31, 2024
| @@ -20,44 +20,44 @@ public class DynamoDBGatewayListProviderHelper | |||
| /// <param name="options"></param> | |||
| internal static void ParseDataConnectionString(string dataConnectionString, DynamoDBGatewayOptions options) | |||
| { | |||
| var parameters = dataConnectionString.Split(new[] { ';' }, StringSplitOptions.RemoveEmptyEntries); | |||
| var parameters = dataConnectionString.Split([ ';' ], StringSplitOptions.RemoveEmptyEntries); | |||
There was a problem hiding this comment.
I think there's an overload now that that takes a char. Isn't that available in the tfm we're targeting?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the recommented way and is starting to be applied throughout the dotnet runtime. See dotnet/runtime#105122.
Applied code fixes for:
Microsoft Reviewers: Open in CodeFlow