Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ship BuildXL assemblies in our VSIX #9185

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Ship BuildXL assemblies in our VSIX #9185

merged 3 commits into from
Aug 30, 2023

Conversation

rainersigwald
Copy link
Member

New dependencies added in #8726 weren't being deployed to VS. Ship them once (rooted in MSBuild\bin) and add binding redirects for the 64-bit versions to use it from there.

@rainersigwald
Ship BuildXL assemblies in our VSIX
133fc96
@rainersigwald
Remove BuildXL NuGet dependencies
6cf7593 
Because BuildXL is not pushed to nuget.org, it's an inconvenient
dependency. But it's not required for API completion so mark it
as a private dependency--it can be satisified by the VS install.
dfederm
dfederm approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@dfederm dfederm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually by deleting the relevant binaries from amd64\* and adding the app config changes.

@rainersigwald rainersigwald merged commit 0974273 into main Aug 30, 2023
@rainersigwald rainersigwald deleted the exp/bxl-setup-authoring branch August 30, 2023 02:00
@rainersigwald rainersigwald mentioned this pull request Aug 30, 2023
Merged
rainersigwald added a commit to rainersigwald/msbuild that referenced this pull request Aug 30, 2023
@rainersigwald
Revert "Ship BuildXL assemblies in our VSIX and not our NuGet packages (
20e8b2f 
dotnet#9185)"

This reverts commit 0974273.
rainersigwald added a commit that referenced this pull request Aug 30, 2023
@rainersigwald
Revert 'Add "cache add" functionality to project caching' (#9188)
3c910ba 
* Revert "Ship BuildXL assemblies in our VSIX and not our NuGet packages (#9185)"

This reverts commit 0974273.

* Revert "Merge pull request #8726 from dfederm/project-cache-vnext"

This reverts commit 462a917, reversing
changes made to 5958b59.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfederm dfederm dfederm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rainersigwald @dfederm