Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let env find bash #8716

Merged
merged 1 commit into from
May 1, 2023
Merged

Let env find bash #8716

merged 1 commit into from
May 1, 2023

Conversation

Thefrank
Copy link
Contributor

Fixes source building under FreeBSD where a symlink has not been made for bash

Context

/bin/bash is standard under OSes that ship with bash installed by default. FreeBSD does not have bash as a default shell.

Changes Made

For portability /usr/bin/env bash is used on the shebang line. This also bring it inline with other dotnet repos.

Testing

none needed?

Notes

env is standard at this point. I have been unable to find a non-historic UNIX-like system that places env in a location exclusively that is not /usr/bin/

Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Forgind Forgind added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label May 1, 2023
@Forgind Forgind merged commit d6fe2b0 into dotnet:main May 1, 2023
@Forgind
Copy link
Member

Forgind commented May 1, 2023

Thanks @Thefrank!

@Thefrank Thefrank deleted the freebsd-shebangfix branch July 12, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants