Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add source generated files properties to project XSD #8683

Merged
merged 5 commits into from
May 1, 2023
Merged

Add source generated files properties to project XSD #8683

merged 5 commits into from
May 1, 2023

Conversation

ryan-rozario
Copy link
Contributor

Fixes #8471

Changes Made

Adds to Autocomplete

  • EmitCompilerGeneratedFiles
  • CompilerGeneratedFilesOutputPath

@ryan-rozario
Copy link
Contributor Author

@dotnet-policy-service agree

1 similar comment
@ryan-rozario
Copy link
Contributor Author

@dotnet-policy-service agree

Forgind
Forgind approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the contribution

@ryan-rozario @Forgind
Update src/MSBuild/MSBuild/Microsoft.Build.CommonTypes.xsd
3cb4218 
Removed a word

Co-authored-by: Forgind <12969783+Forgind@users.noreply.github.com>
rainersigwald
rainersigwald reviewed Apr 20, 2023
View reviewed changes
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotnet/roslyn-compiler can we get a review of these IntelliSense descriptions of source-generator-behavior-control properties please?

@rainersigwald rainersigwald requested a review from a team April 20, 2023 19:25
rainersigwald
rainersigwald approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ryan-rozario @rainersigwald
Changed if to whether to maintain consistency
ccfa812 
Preferred Conditional Conjunctions: Whether

Co-authored-by: Rainer Sigwald <raines@microsoft.com>
@Forgind Forgind added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Apr 24, 2023
@Forgind Forgind merged commit 322e417 into dotnet:main May 1, 2023
@Youssef1313
Copy link
Member

@Forgind @rainersigwald which VS version will include this fix?

@rainersigwald
Copy link
Member

17.7. Should be in preview 2.

@ryan-rozario ryan-rozario deleted the sourcegenerator_autocompletion branch May 22, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpar jaredpar jaredpar approved these changes

@RikkiGibson RikkiGibson RikkiGibson left review comments

@rainersigwald rainersigwald rainersigwald approved these changes

@Forgind Forgind Forgind approved these changes

Assignees
No one assigned
Labels
merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EmitCompilerGeneratedFiles and CompilerGeneratedFilesOutputPath are not present in auto completion
6 participants
@ryan-rozario @Youssef1313 @rainersigwald @jaredpar @RikkiGibson @Forgind