Code cleanup in Microsoft.Common.tasks #8657
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # (Issue to be created)
Context
Minor code cleanup in Microsoft.Common.tasks.
Changes Made
Removed duplicate
UsingTask
for theResolveSDKReference
task. The redundantResolveSDKReference
doesn't seem to create harm but is not useful.Alphabetized the
UsingTask
elements. Retained the separate grouping of Roslyn tasks. Retained the blank lines around tasks that have different Runtimes and/or Conditions (i.e.GenerateResource
,RegisterAssembly
, andUnregisterAssembly
). Ordering theUsingTask
elements is intended to aid inspection and maintenance of tasks.Testing
Tested on Windows 11 and macOS 12. Tested by running unit tests and by having this change in several development branches where msbuild has been run on project files.
Notes
This change is included in the implementation for #8613, which is PR #8614.