[FancyLogger] Footer shows progress bar of completed projects #8314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgind
reviewed
Jan 19, 2023
rainersigwald
approved these changes
Jan 20, 2023
Forgind
approved these changes
Jan 20, 2023
28 tasks
Conflicts: src/MSBuild/LiveLogger/LiveLogger.cs src/MSBuild/LiveLogger/TerminalBuffer.cs
|
I merged main in again and it still look ok:
|
Forgind
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Context
The FancyLogger should allow users to know currently relevant information of their build; namely, how much is completed vs how much is missing.
The current approach is showing the percentage of completed projects at any given moment:
FinishedProjects/StartedProjects.Changes Made
The footer at the bottom of the build shows a progress bar reflecting the percentage of the build, as well as a legend indicating the user they can scroll using the keyboard arrows.
Testing
Notes