Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update XSD to include details about ImplicitUsings and Using items #6755

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Update XSD to include details about ImplicitUsings and Using items #6755

merged 1 commit into from
Aug 16, 2021

Conversation

pranavkm
Copy link
Contributor

Fixes #6745

The SDK added a few new features that are enabled in .NET 6 C# projects. Updating the schema file to document this feature.

Forgind
Forgind approved these changes Aug 13, 2021
View reviewed changes
Copy link
Member

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we'll have to follow https://github.com/dotnet/msbuild/blob/main/documentation/wiki/Localization.md#localizing-xsd-intellisense

src/MSBuild/MSBuild/Microsoft.Build.CommonTypes.xsd
</xs:documentation>
</xs:annotation>
</xs:attribute>
<xs:attribute name="Static" type="msb:boolean" use="optional">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this one exist already, or is it just planned?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It exists - https://github.com/dotnet/sdk/blob/main/src/Tasks/Microsoft.NET.Build.Tasks/GenerateGlobalUsings.cs#L69, just not used by any of the implicitly defined ones.

@rainersigwald
Copy link
Member

Note that we'll have to follow https://github.com/dotnet/msbuild/blob/main/documentation/wiki/Localization.md#localizing-xsd-intellisense

I have great news: #6759.

@Forgind
Copy link
Member

Forgind commented Aug 13, 2021

Note that we'll have to follow https://github.com/dotnet/msbuild/blob/main/documentation/wiki/Localization.md#localizing-xsd-intellisense

I have great news: #6759.

I completely forgot about that! 🎉

@pranavkm
Copy link
Contributor Author

Guess this PR is good to go. Could one of you merge it?

@rainersigwald rainersigwald added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Aug 13, 2021
@drewnoakes drewnoakes mentioned this pull request Aug 16, 2021
Closed
@rokonec rokonec merged commit 9c14af5 into main Aug 16, 2021
@rainersigwald rainersigwald deleted the prkrishn/xsd branch October 19, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Forgind Forgind Forgind approved these changes

@rainersigwald rainersigwald rainersigwald approved these changes

@ladipro ladipro Awaiting requested review from ladipro

@DamianEdwards DamianEdwards Awaiting requested review from DamianEdwards

Assignees
No one assigned
Labels
merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update schema for ImplicitUsings feature
4 participants
@pranavkm @rainersigwald @Forgind @rokonec