Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ref assemblies in more locations #2181

Merged
merged 2 commits into from
Aug 1, 2017

Conversation

rainersigwald
Copy link
Member

@rainersigwald rainersigwald commented Jun 6, 2017

Need to confirm these changes with owners of:

  • WinMDExp
  • LC

Continuation of #2167 for the post-15.3 timeframe.

@rainersigwald rainersigwald mentioned this pull request Jun 6, 2017
@rainersigwald rainersigwald added this to the MSBuild 15.6 milestone Jun 7, 2017
@rainersigwald
Copy link
Member Author

@yizhang82 Can you confirm that WinMDExp only looks at the public interface of managed assemblies passed to it with /reference:? If so, this change will mean that the ExportWindowsMDFile can be skipped more often in incremental builds, because it will only run when the public interface of a reference changes, rather than when any change is made to the referenced assembly.

@yizhang82
Copy link

@rainersigwald Yes, we only care about public contracts in the reference assemblies.

Copy link
Contributor

@AndyGerlicher AndyGerlicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split into two commits and merge.

@rainersigwald rainersigwald merged commit d0d089c into dotnet:master Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants