Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live logger trims the message ID for SDK messages #8393

Closed
Tracked by #8370
marcpopMSFT opened this issue Feb 2, 2023 · 0 comments · Fixed by #8397
Closed
Tracked by #8370

Live logger trims the message ID for SDK messages #8393

marcpopMSFT opened this issue Feb 2, 2023 · 0 comments · Fixed by #8397
Labels
triaged

Comments

@marcpopMSFT
Copy link
Member

marcpopMSFT commented Feb 2, 2023 •
edited
Loading

The console logger includes NETSDK1057 but the live logger doesn't. Not sure if it's all messages or just this one. Including the message ID is useful when searching for messages from customer reports.

Warnings work correctly.
Haven't tried errors.

image

image
@marcpopMSFT marcpopMSFT mentioned this issue Feb 2, 2023
Open
28 tasks
@edvilme edvilme mentioned this issue Feb 3, 2023
Merged
JaynieBai pushed a commit that referenced this issue Feb 7, 2023
@edvilme
[LiveLogger] Add code to high priority messages (#8397)
e1b3bf9 
Fixes #8393

Context
Currently the live logger does not log the message id's. Including the message ID is useful when searching for messages from customer reports.

Changes Made
When receiving BuildMessageEventArgs, the Code is now also passed to MessageNode and printed on the display.
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[LiveLogger] Add code to high priority messages edvilme/msbuild
2 participants
@marcpopMSFT @AR-May