Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
  • Loading branch information
ladipro and rainersigwald authored Aug 2, 2021
1 parent 906f2eb commit bf1a7d9
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion eng/build.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ function Check-RequiredVersionBumps() {
git --no-pager diff --unified --no-color --exit-code -w origin/$env:SYSTEM_PULLREQUEST_TARGETBRANCH HEAD src\Framework\BuildEngineInterface.cs `
| Select-String -Pattern "int Version =" | ForEach-Object -process { $versionLineChanged = $true }
if (($LASTEXITCODE -ne 0) -and (-not $versionLineChanged)) {
throw "##vso[task.logissue type=error] Detected changes in Framework\BuildEngineInterface.cs without a version bump. " +
throw "##vso[task.logissue type=error;sourcepath=src/Framework/BuildEngineInterface.cs] Detected changes in Framework\BuildEngineInterface.cs without a version bump. " +
"If you are making API changes, please bump the version. " +
"If the changes in the file are cosmetic, please add/change a comment on the Version prop to silence the error."
}
Expand Down
2 changes: 1 addition & 1 deletion src/Build/BackEnd/Components/Logging/LoggingService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1594,7 +1594,7 @@ private void UpdateMinimumMessageImportance(ILogger logger)
// The null logger has no effect on minimum verbosity.
Execution.BuildManager.NullLogger => null,

// If the logger is not on our whitelist, there are no importance guarantees. Fall back to "any importance".
// If the logger is not on our allowlist, there are no importance guarantees. Fall back to "any importance".
_ => MessageImportance.Low
};

Expand Down
2 changes: 1 addition & 1 deletion src/MSBuild/OutOfProcTaskHostNode.cs
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,7 @@ public void ReleaseCores(int coresToRelease)
private sealed class BuildEngineInterfaceImpl : BuildEngineInterface
{
/// <summary>
/// No logging verbosity optimization in OOP nodes.
/// No logging verbosity optimization in TaskHost nodes.
/// </summary>
public override bool LogsMessagesOfImportance(MessageImportance importance) => true;
}
Expand Down

0 comments on commit bf1a7d9

Please sign in to comment.